Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-4886: Fix SPDX license identifier #5232

Merged
merged 6 commits into from
Sep 4, 2022
Merged

Update EIP-4886: Fix SPDX license identifier #5232

merged 6 commits into from
Sep 4, 2022

Conversation

Pandapip1
Copy link
Member

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 12, 2022 •
edited
Loading

A critical exception has occurred:
Message: pr 5232 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

@Pandapip1 Pandapip1 closed this Jul 14, 2022
@Pandapip1 Pandapip1 reopened this Jul 14, 2022
@Pandapip1
Copy link
Member Author

Bump.

@lightclient
Copy link
Member

Same issue as mentioned here: #5227 (comment)

@Pandapip1 Pandapip1 closed this Jul 28, 2022
@Pandapip1 Pandapip1 reopened this Jul 28, 2022
@eth-bot eth-bot enabled auto-merge (squash) July 28, 2022 14:52
@Pandapip1 Pandapip1 mentioned this pull request Aug 1, 2022
Closed
@Pandapip1 Pandapip1 changed the title Fix SPDX license identifier in EIP-4886 EIP-4886: Fix SPDX license identifier Aug 28, 2022
@Pandapip1
Copy link
Member Author

CC @omnus

@Pandapip1 Pandapip1 changed the title EIP-4886: Fix SPDX license identifier Update EIP-4886: Fix SPDX license identifier Aug 28, 2022
@omnus
Copy link
Contributor

omnus commented Sep 4, 2022

CC @omnus

So sorry, thank you for the ping 🙏

@eth-bot eth-bot merged commit 792b7d6 into ethereum:master Sep 4, 2022
@Pandapip1 Pandapip1 deleted the 4886-assets-cc0 branch September 5, 2022 11:46
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@Pandapip1 @nachomazzara
Update EIP-4886: Fix SPDX license identifier (ethereum#5232)
d1ef7d0 
* Fix SPDX license identifier in EIP-4886

* Satisfy eth bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omnus omnus omnus approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Pandapip1 @eth-bot @lightclient @omnus @SamWilsn