Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-4675: Fix SPDX license identifier #5231

Merged
merged 7 commits into from
Oct 8, 2022
Merged

Update EIP-4675: Fix SPDX license identifier #5231

merged 7 commits into from
Oct 8, 2022

Conversation

Pandapip1
Copy link
Member

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 12, 2022 •
edited
Loading

A critical and unhandled exception has occurred:
Message: not found
Data: (there is no data for this error)(cc @alita-moore, @mryalamanchi)

@Pandapip1 Pandapip1 closed this Jul 14, 2022
@Pandapip1 Pandapip1 reopened this Jul 14, 2022
@Pandapip1
Copy link
Member Author

Bump.

@poojaranjan poojaranjan mentioned this pull request Jul 26, 2022
Closed
@lightclient
Copy link
Member

Same issue as mentioned here: #5227 (comment)

@github-actions
Copy link

The commit acf31d6 (as a parent of 967a809) contains errors. Please inspect the Run Summary for details.

@Pandapip1 Pandapip1 closed this Jul 28, 2022
@Pandapip1 Pandapip1 reopened this Jul 28, 2022
@eth-bot eth-bot enabled auto-merge (squash) July 28, 2022 14:52
@github-actions
Copy link

The commit acf31d6 (as a parent of 658b654) contains errors. Please inspect the Run Summary for details.

@Pandapip1 Pandapip1 mentioned this pull request Aug 1, 2022
Closed
@Pandapip1
Copy link
Member Author

All assets should be CC0. Exceptions can be made, but in general, assets being the same license as the EIP itself is the policy.

This is primarily to help aid the adoption of your EIP so that people aren't concerned about using your assets due to unfamiliar or incompatible licenses.

@Pandapip1
Copy link
Member Author

@PowerStream3604 please approve this PR

PowerStream3604
PowerStream3604 previously approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@PowerStream3604 PowerStream3604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve changing the License

eth-bot
eth-bot previously approved these changes Aug 17, 2022
View reviewed changes
@Pandapip1
Copy link
Member Author

@SamWilsn I request a manual merge.

@Pandapip1 Pandapip1 changed the title Fix SPDX license identifier in EIP-4675 EIP-4675: Fix SPDX license identifier Aug 28, 2022
@Pandapip1 Pandapip1 changed the title EIP-4675: Fix SPDX license identifier Update EIP-4675: Fix SPDX license identifier Aug 28, 2022
@Pandapip1 Pandapip1 added this to the Manual Merge milestone Aug 28, 2022
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 12, 2022
@Pandapip1
Copy link
Member Author

Still an issue.

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 13, 2022
xinbenlv
xinbenlv reviewed Sep 24, 2022
View reviewed changes
assets/eip-4675/contracts/ERC20Token.sol
@@ -1,4 +1,4 @@
// SPDX-License-Identifier: MIT
// SPDX-License-Identifier: CC0-1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we shall ask the author to grant it with new license....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did ask, and the author approved.

@Pandapip1 Pandapip1 dismissed stale reviews from eth-bot, PowerStream3604, and ghost via 448be28 September 26, 2022 22:49
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-erc labels Sep 26, 2022
@Pandapip1
Copy link
Member Author

Needs manual merge due to deleting a file.

@SamWilsn SamWilsn disabled auto-merge October 8, 2022 01:28
@SamWilsn SamWilsn merged commit 0d5c73a into ethereum:master Oct 8, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@Pandapip1 @nachomazzara
Update EIP-4675: Fix SPDX license identifier (ethereum#5231)
1620841 
* Fix SPDX license identifier in EIP-4675

* Satisfy eth bot

* Delete SafeMath.sol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinbenlv xinbenlv xinbenlv left review comments

@SamWilsn SamWilsn SamWilsn requested changes

@eth-bot eth-bot eth-bot left review comments

@PowerStream3604 PowerStream3604 PowerStream3604 left review comments

Assignees
No one assigned
Labels
c-update Modifies an existing proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
Manual Merge Queue
Development

Successfully merging this pull request may close these issues.
6 participants
@Pandapip1 @eth-bot @lightclient @PowerStream3604 @xinbenlv @SamWilsn