Update EIP-4907: Cleanup trailing whitespaces #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A critical exception has occurred: |
TimDaub
force-pushed
the
fix/eip-4907-clean-trailing-whitespace
branch
from
1dcd2ca to
8cb4188
Compare
|
You must make some sort of change to the EIP too so that the automerger bot can merge this. |
|
Since this is a final EIP, and some of the changes are more than just pure whitespace (changing quote style and adding parentheses), I am going to err on the side of caution and recommend that we don't apply these changes. |
|
I disagree. If it doesn't change anything functional, it's fine. |
Pandapip1
previously approved these changes
Aug 19, 2022
Pandapip1
changed the title
Pandapip1
changed the title
github-actions
bot
added
c-update
Pandapip1
approved these changes
Sep 2, 2022
|
Thank you @TimDaub . |
0xanders
approved these changes
Sep 3, 2022
eth-bot
approved these changes
Sep 3, 2022
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
* Cleanup trailing whitespaces * Make small change so that CI passes Co-authored-by: Pandapip1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
when I tried using your implementation, my editor showed me lots of occurrences with trailing whitespace and I thought I'd fix it once and for all at the source. This doesn't really change any functionality so I hope it can get merged despite the standard being marked as final.