-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust EIP-4973 interface to add function give(...)
and function take(...)
#5209
Conversation
function give(...)
and function take(...)
All tests passed; auto-merging...(pass) eip-4973.md
(pass) assets/eip-4973/ERC-4973.sol
|
How about |
neither give or take "revoke" something. For both give and take the agreement of a second party is required:
|
The commit a31ff62 (as a parent of 31e9f3a) contains errors. Please inspect the Run Summary for details. |
The commit a4c7487 (as a parent of e82d819) contains errors. Please inspect the Run Summary for details. |
The commit 146462d (as a parent of 8727fb9) contains errors. Please inspect the Run Summary for details. |
The commit f9e151c (as a parent of af90077) contains errors. Please inspect the Run Summary for details. |
The commit 9d70058 (as a parent of fbe2ffc) contains errors. Please inspect the Run Summary for details. |
Decided against implementing this change for now. Will maybe follow up later when we have better information. |
The commit 3a3618c (as a parent of 6b934ae) contains errors. Please inspect the Run Summary for details. |
…ake(...)` (ethereum#5209) * Add new interface definition * Add flat file reference implementation * Replace Attest/Revoke with Transfer event * Change burn to unequip * Fix transfer requirement of take fn * Add security considerations section * Require EIP-1271 * Describe EIP-712 signature creation * Fix tabs * Link to EIP-712 * Adjust code type to js * Finalize flat file reference impl. * Require 2098 not 2089
This PR isn't ready for merging or review yet. But if you wanna help, feel free to comment below anyways.
TODOs:
event Revoke
andevent Attest
function burn
tofunction unequip
string tokenURIs
as was outlined here https://github.com/otterspace-xyz/EIPs/pull/1/files#diff-78eda02f8170e73250f20c44a63a94888296116f3fec90171d5e766ce312f5afR228