Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust EIP-4973 interface to add function give(...) and function take(...) #5209

Merged
merged 13 commits into from
Aug 1, 2022

Conversation

TimDaub
Copy link
Contributor

@TimDaub TimDaub commented Jul 8, 2022

This PR isn't ready for merging or review yet. But if you wanna help, feel free to comment below anyways.

TODOs:

@TimDaub TimDaub changed the title Add new interface definition Adjust EIP-4973 interface to add function give(...) and function take(...) Jul 8, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 8, 2022

All tests passed; auto-merging...

(pass) eip-4973.md

classification
updateEIP
  • passed!

(pass) assets/eip-4973/ERC-4973.sol

classification
ambiguous
  • file assets/eip-4973/ERC-4973.sol is associated with EIP 4973; because there are also changes being made to EIPS/eip-4973.md all changes to corresponding assets are also allowed

@Pandapip1
Copy link
Member

Pandapip1 commented Jul 8, 2022

How about grant/revoke instead of give/take?

@TimDaub
Copy link
Contributor Author

TimDaub commented Jul 9, 2022

How about grant/revoke instead of give/take?

neither give or take "revoke" something. For both give and take the agreement of a second party is required:

  • take(from,... signature) takes from "address from" (in case signature is valid) and mints to the msg.sender
  • give(to,..., signature) mints from the msg.sender to "address to" if their signature is valid

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

The commit a31ff62 (as a parent of 31e9f3a) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

The commit a4c7487 (as a parent of e82d819) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

The commit 146462d (as a parent of 8727fb9) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

The commit f9e151c (as a parent of af90077) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

The commit 9d70058 (as a parent of fbe2ffc) contains errors. Please inspect the Run Summary for details.

@TimDaub
Copy link
Contributor Author

TimDaub commented Aug 1, 2022

Decided against implementing this change for now. Will maybe follow up later when we have better information.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

The commit 3a3618c (as a parent of 6b934ae) contains errors. Please inspect the Run Summary for details.

@TimDaub TimDaub marked this pull request as ready for review August 1, 2022 10:29
@TimDaub TimDaub closed this Aug 1, 2022
@TimDaub TimDaub reopened this Aug 1, 2022
@eth-bot eth-bot enabled auto-merge (squash) August 1, 2022 10:30
@eth-bot eth-bot merged commit 60bc288 into ethereum:master Aug 1, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
…ake(...)` (ethereum#5209)

* Add new interface definition

* Add flat file reference implementation

* Replace Attest/Revoke with Transfer event

* Change burn to unequip

* Fix transfer requirement of take fn

* Add security considerations section

* Require EIP-1271

* Describe EIP-712 signature creation

* Fix tabs

* Link to EIP-712

* Adjust code type to js

* Finalize flat file reference impl.

* Require 2098 not 2089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants