MULDIV instruction #5000
Merged
MULDIV instruction #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWilsn
reviewed
Apr 14, 2022
EIPS/eip-draft-muldiv.md
Outdated
| @@ -0,0 +1,147 @@ | |||
| --- | |||
| eip: nnn | |||
There was a problem hiding this comment.
Suggested change
| eip: nnn | |
| eip: 4998 |
Since we try to discourage sniping "fancy" EIP numbers, and this PR was opened immediately after a spam bot posted issue 4999, I'm reassigning to a less special number.
There was a problem hiding this comment.
@SamWilsn PR was merged as EIP-5000?
There was a problem hiding this comment.
Yep, that was @lightclient's decision.
lightclient
requested changes
May 3, 2022
EIPS/eip-draft-muldiv.md
Outdated
| title: MULDIV instruction | ||
| description: | ||
| author: Harikrishnan Mulackal (@hrkrshnn), Alex Beregszaszi (@axic), Paweł Bylica (@chfast) | ||
| discussions-to: |
lightclient
requested changes
Jul 13, 2022
EIPS/eip-draft-muldiv.md
Outdated
| --- | ||
| eip: nnn | ||
| title: MULDIV instruction | ||
| description: |
All tests passed; auto-merging...(pass) eip-5000.md
|
lightclient
reviewed
Jul 13, 2022
MicahZoltu
added a commit
that referenced
this pull request
Jul 14, 2022
This appears to be authored by someone actively attacking the EIP numbering system. Not only did they appear to number snipe, but they blatantly ignored editor number assignment and picked the number they wanted anyway. It was merged, but I suspect the editor who approved it just missed the assignment comment because it was marked by GitHub as "resolved". Timeline: * At around 18 minutes after the hour, a spammer created issue #4998. This has since been deleted as spam. * At around 19 minutes after the hour, a spammer created issue #4999. This has since been deleted as spam. * At around 19 minutes after the hour, @hrkrshnn created PR #5000. * An hour and 7 minutes later [Sam reviewed it](#5000 (review)) and assigned number 4998 with a comment indicating why 5000 wasn't assigned. * ~18 days later (with no updates from the author) [lightclient reviewed it](#5000 (review)) * ~Over two months later (still no updates from the author) [lightclient reviewed it again](#5000 (review)) * About an hour after that the author made the [first change](edaa3fb) to the PR, in which they ignored Sam's assigned number and took 5000 anyway. * Review proceeded from there as normal and was eventually merged. ---- We have a serious spam problem on this repository and it is a huge editor time sink. At best, the author of this PR wasn't the spammer but they were running a number squatting bot and they blatantly ignored editor number assignment. At worst they are also the spammer and part of a serious problem. I propose we delete this EIP and either ban the author from the repository for this behavior. The blatant disregard for an editor's number assignment without discussion combined with the blatant number sniping makes me classify this as an active attack. ---- Also, since an editor is a co-author on this EIP I think this case should be taken *far* more seriously than normal. Editors should be held to a far higher standard than regular drive-by authors and while I am not suggesting @axic played an active role in this attack (they may not have known about it), I think that a strong show of intolerance against malicious behavior here is necessary due to this association as we cannot be seen to be giving preferential treatment to editors.
Closed
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
* Add MULDIV draft * Fixed the number and a typo * Add description and discussions-to * Fixed a trailing whitespace Co-authored-by: Alex Beregszaszi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new instruction,
MULDIV(x, y, z), to perform((x * y) / z) % 2**256in 512-bit precision.z = 0is a special case for(x * y) / 2**256.