Updated months to be more accurate for the iceage #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbeiko
reviewed
May 12, 2021
| created: 2021-05-06 | ||
| --- | ||
|
|
||
| ## Simple Summary | ||
| Delays the difficulty bomb to show effect the first week of December 2021. | ||
|
|
||
| ## Abstract | ||
| Starting with `FORK_BLOCK_NUMBER` the client will calculate the difficulty based on a fake block number suggesting to the client that the difficulty bomb is adjusting 9,500,000 blocks later than the actual block number. | ||
| Starting with `FORK_BLOCK_NUMBER` the client will calculate the difficulty based on a fake block number suggesting to the client that the difficulty bomb is adjusting 9,666,666 blocks later than the actual block number. |
There was a problem hiding this comment.
Missed this spot, @MadeofTin: should be 9 700 000 like the rest.
Suggested change
| Starting with `FORK_BLOCK_NUMBER` the client will calculate the difficulty based on a fake block number suggesting to the client that the difficulty bomb is adjusting 9,666,666 blocks later than the actual block number. | |
| Starting with `FORK_BLOCK_NUMBER` the client will calculate the difficulty based on a fake block number suggesting to the client that the difficulty bomb is adjusting 9,700,000 blocks later than the actual block number. |
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
This was referenced May 12, 2021
Tyrael
reviewed
May 13, 2021
| created: 2021-05-06 | ||
| --- | ||
|
|
||
| ## Simple Summary | ||
| Delays the difficulty bomb to show effect the first week of December 2021. | ||
|
|
||
| ## Abstract | ||
| Starting with `FORK_BLOCK_NUMBER` the client will calculate the difficulty based on a fake block number suggesting to the client that the difficulty bomb is adjusting 9,500,000 blocks later than the actual block number. | ||
| Starting with `FORK_BLOCK_NUMBER` the client will calculate the difficulty based on a fake block number suggesting to the client that the difficulty bomb is adjusting 9,666,666 blocks later than the actual block number. | ||
|
|
||
| ## Motivation | ||
| Targeting for the Shanghai upgrde and/or the Merge to occur before Decemember 2021. Either the bomb can be readjusted at that time, or removed all together. |
There was a problem hiding this comment.
there is a typo in upgrde, should be upgrade
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
* Updated months to be more accurate. * Updated number difficulty delay targeting block 13766666 https://etherscan.io/block/countdown/13766666 * Change status to Review * Pushed back so .1 starts in early december.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made mistake in the date calculations. Updated to be more accurate and the Proposal is ready for Review.