Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-2565 to clarify specification #2892

Merged
merged 18 commits into from
Oct 8, 2020
Merged

Update EIP-2565 to clarify specification #2892

merged 18 commits into from
Oct 8, 2020

Commits on Aug 21, 2020

  1. Move from EIP-2565 from 'Last Call' to 'Accepted'

    @ineffectualproperty
    ineffectualproperty authored Aug 21, 2020
    Configuration menu
    Copy the full SHA
    2671b29 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Use relative paths for EIP links

    @ineffectualproperty
    ineffectualproperty authored Aug 24, 2020
    Configuration menu
    Copy the full SHA
    cca0062 View commit details
    Browse the repository at this point in the history

  2. Update relative path to EIP-198 

    Co-authored-by: Micah Zoltu <[email protected]>
    @ineffectualproperty @MicahZoltu
    ineffectualproperty and MicahZoltu authored Aug 24, 2020
    Configuration menu
    Copy the full SHA
    faeb380 View commit details
    Browse the repository at this point in the history

  3. Update relative path to EIP-198 pt 2 

    Co-authored-by: Micah Zoltu <[email protected]>
    @ineffectualproperty @MicahZoltu
    ineffectualproperty and MicahZoltu authored Aug 24, 2020
    Configuration menu
    Copy the full SHA
    0b2ac2f View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Update to clarify EIP specification

    @ineffectualproperty
    ineffectualproperty authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    d4a5346 View commit details
    Browse the repository at this point in the history

  2. Delete library benchmarks from specification

    @ineffectualproperty
    ineffectualproperty authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    6a64561 View commit details
    Browse the repository at this point in the history

  3. Extend last call review period

    @ineffectualproperty
    ineffectualproperty authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    e47499a View commit details
    Browse the repository at this point in the history

  4. Update mult complexity to represent limb in bytes

    @ineffectualproperty
    ineffectualproperty authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    277ef6b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Strengthen EIP language 

    Co-authored-by: Martin Holst Swende <[email protected]>
    @ineffectualproperty @holiman
    ineffectualproperty and holiman authored Sep 24, 2020
    Configuration menu
    Copy the full SHA
    85378e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Tighten spec and add implementations section

    @ineffectualproperty
    ineffectualproperty authored Oct 1, 2020
    Configuration menu
    Copy the full SHA
    edea934 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Rather than continuing to go back and forth, I thought maybe just sub… 

    …mitting a PR that expresses my recommendations would be easier.

The entire gas algorithm is encoded in this EIP without needing to reference 198.
Other sections were also adjusted to no longer reference 198.
Also removed unnecessary variables like `GQUADDIVISOR`, since that can just be baked into the algorithm and we don't need to talk about it separately (just like the squaring is baked in without defining a special variable that just means `2`).

Notes:
1. There are a couple of TODOs left in, I figure you'll be better able to address them than I.
2. Verify that the algorithm I wrote up is accurate!  I tried figure it out from this EIP and 198, but it was tough because neither just clearly defined the algorithm in code in a single place.
3. I recommend updating the images if possible to mention EIP-198 and EIP-2565 rather than "current" and "proposed".
    Micah Zoltu committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    1015d6c View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Merge pull request #1 from ethereum/2565 

    2565 last call adjustments.
    @ineffectualproperty
    ineffectualproperty authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    d337dd8 View commit details
    Browse the repository at this point in the history

  2. Fix spelling and TODOs, add Python implementation

    @ineffectualproperty
    ineffectualproperty authored Oct 6, 2020
    Configuration menu
    Copy the full SHA
    5dc7cc2 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Updates simple summary text 

    Co-authored-by: Micah Zoltu <[email protected]>
    @ineffectualproperty @MicahZoltu
    ineffectualproperty and MicahZoltu authored Oct 7, 2020
    Configuration menu
    Copy the full SHA
    6393f0e View commit details
    Browse the repository at this point in the history

  2. Remove reference to EIP-198 variable 

    Co-authored-by: Micah Zoltu <[email protected]>
    @ineffectualproperty @MicahZoltu
    ineffectualproperty and MicahZoltu authored Oct 7, 2020
    Configuration menu
    Copy the full SHA
    e398ee6 View commit details
    Browse the repository at this point in the history

  3. Update EIP title

    @ineffectualproperty
    ineffectualproperty authored Oct 7, 2020
    Configuration menu
    Copy the full SHA
    7ba236e View commit details
    Browse the repository at this point in the history

  4. Fix image titles and legends

    @ineffectualproperty
    ineffectualproperty authored Oct 7, 2020
    Configuration menu
    Copy the full SHA
    5b00e67 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into patch-1

    @ineffectualproperty
    ineffectualproperty authored Oct 7, 2020
    Configuration menu
    Copy the full SHA
    78260c6 View commit details
    Browse the repository at this point in the history