Fix eip-1679 rendering #2873
Merged
Fix eip-1679 rendering #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also just realized there was a typo on this EIP updating the ordering of the required EIPs. I have fixed this and I rereviewed #2860 for any other typos and it looks good. |
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
The HTML generator is having trouble with the double colon in the title line of EIP-1679. I removed the quotes when adding the new validator, and for some reason the HTML generator raised it as a warning rather than an error. I've logged this issue with eipv, but we should go ahead and fix this ASAP.
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
The HTML generator is having trouble with the double colon in the title line of EIP-1679. I removed the quotes when adding the new validator, and for some reason the HTML generator raised it as a warning rather than an error. I've logged this issue with eipv, but we should go ahead and fix this ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML generator is having trouble with the double colon in the title line of EIP-1679. I removed the quotes when adding the new validator, and for some reason the HTML generator raised it as a warning rather than an error. I've logged this issue with
eipv, but we should go ahead and fix this ASAP.