Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Stagnant and Withdrawn EIPs less visible #6027

Closed
Pandapip1 opened this issue Nov 22, 2022 · 13 comments
Closed

Make Stagnant and Withdrawn EIPs less visible #6027

Pandapip1 opened this issue Nov 22, 2022 · 13 comments
Labels
e-consensus Waiting on editor consensus enhancement r-website Relates to the Website w-stale Waiting on activity

Comments

@Pandapip1
Copy link
Member

Proposed Change

Pretty self-explanatory. Just remove the Stagnant and Withdrawn sections.

Thoughts?

@Pandapip1 Pandapip1 added enhancement r-website Relates to the Website e-consensus Waiting on editor consensus labels Nov 22, 2022
@abcoathup
Copy link
Contributor

Stagnant and Withdrawn show what has gone before, which is useful for EIP authors to check for existing EIPs when creating a new one.

What about having a filter hiding them by default, would that meet your goal?

@xinbenlv
Copy link
Contributor

xinbenlv commented Nov 28, 2022

+1 Also, consider hiding Draft

@axic
Copy link
Member

axic commented Nov 28, 2022

I think it is a bad idea. They are separated by status for a reason. Filtering could be added to the site, but hiding without any recurse defeats the purpose, imho.

@xinbenlv
Copy link
Contributor

xinbenlv commented Nov 28, 2022

I think a filter to hide Stagnant, Withdrawn and Draft by default with option to show and search will a great way to go.

When authoring new EIP, a PR/issue template could send reader to a direct link that unhide these EIPs and ask them to go through existing / historical EIPs.

@Pandapip1
Copy link
Member Author

I could make the toggle with relative ease. #6017 would need to be merged first, though, as it adds all the necessary stuff in order to be able to make these more advanced changes.

@gcolvin
Copy link
Contributor

gcolvin commented Dec 14, 2022

I'm with @axic, and then some. It causes more harm and confusion than good to hide them.

@Pandapip1
Copy link
Member Author

Pandapip1 commented Dec 14, 2022

It causes more harm and confusion than good to hide them.

I think it causes more harm and confusion to leave them there, implying that they're still mostly okay to use (despite the big red warning).

Regardless, what are your thoughts about the toggle option?

@SamWilsn SamWilsn changed the title Hide Stagnant and Withdrawn EIPs from the EIP list Make Stagnant and Withdrawn EIPs less visible Jan 25, 2023
@SamWilsn
Copy link
Contributor

SamWilsn commented Jan 25, 2023

As discussed on EIPIP today, @gcolvin and I are fine with making Stagnant and Withdrawn EIPs less visible, but not removing them entirely from the list. Whether that's a toggle that's default collapsed, or some other method is undecided. I guess do what you think is best @Pandapip1 :P

@ethereum ethereum deleted a comment from tecywiz121 Jan 25, 2023
@Pandapip1
Copy link
Member Author

A toggle it is.

@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 15, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Feb 19, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 1, 2023
@Pandapip1 Pandapip1 linked a pull request Mar 1, 2023 that will close this issue
6 tasks
@github-actions
Copy link

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus enhancement r-website Relates to the Website w-stale Waiting on activity
Projects
None yet
8 participants
@axic @xinbenlv @gcolvin @abcoathup @Pandapip1 @SamWilsn and others