-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENUM as ABI type #47
Comments
Any ideas for the notation? As we kind of settled for anonymous structs in the other EIP, enums should also be anonymous. |
Well it's an array of strings right? Shouldn't it be |
I would say that it is rather a list of identifiers instead of strings. Furthermore, I think it would be a good idea to differentiate enums from a tuple/struct types. |
On first glance, |
Which other EIP are you referring to? I've only found the timestamps prior to this one. Would it be any harm making it more explicit such as Just trying to avoid a situation where new types will have a weird notation to avoid collisions. |
I was referring to this proposal here: #21 My reasoning behind not using explicit |
I don't think it would hurt to have However, usually |
There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
to address solana/caip2 inconsistencies pointed out online
A FAQ on the solidity docs:
Enums would actually very useful types to be exposed on the ABI, specially for auto generated interfaces on the wallet and on abi2html, for example. On the read side, properties could be exposed as words instead of meaningless integers. On the execute side, enums could be rendered as drop down or radio boxes.
This would make interface creation easier.
The text was updated successfully, but these errors were encountered: