fix: take address from cli for tictactoe frontend #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamdiallam
requested changes
Nov 24, 2024
|
ty!! will locally test this and merge in after getting off my flight :) |
hamdiallam
requested changes
Nov 27, 2024
|
Looks good! Sorry one last request to also remove the otherwise good to go |
hamdiallam
approved these changes
Nov 28, 2024
|
@tabshaikh npm_config style reading doesn't work for pnpm so superseding this functionality with env vars in #288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tictactoe frontend uses a hardcoded address which may fail on changes. so adding a cli flag
--address=.How to run it:
#274