Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-chain: print plasma error message #559

Merged
merged 4 commits into from
Sep 10, 2024
Merged

add-chain: print plasma error message #559

merged 4 commits into from
Sep 10, 2024

Conversation

bitwiseguy
Copy link
Collaborator

Fixes #557

Print an error message if any legacy plasma fields are present in the chain's rollup.json when the add-chain command is run. The error message points the user to the docs section that describes how to adjust the rollup.json to use the new altda name and config format.

@bitwiseguy bitwiseguy marked this pull request as ready for review September 9, 2024 16:27
@bitwiseguy bitwiseguy requested a review from a team as a code owner September 9, 2024 16:27
Copy link
Collaborator

@geoknee geoknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

add-chain/config/plasma.go Outdated Show resolved Hide resolved
superchain/superchain.go Show resolved Hide resolved
add-chain/config/config.go Show resolved Hide resolved
@bitwiseguy bitwiseguy merged commit b3905c8 into main Sep 10, 2024
13 checks passed
@bitwiseguy bitwiseguy deleted the ss/plasma-warning branch September 10, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add-chain should detect legacy rollup.json formats using "plasma"
2 participants