Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circleci: use context to pass rpc urls #544

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

bitwiseguy
Copy link
Collaborator

@bitwiseguy bitwiseguy commented Sep 3, 2024

Description

Fixes an issue where forked pull requests cannot use rpc endpoints stored as project level env vars in circle ci. Instead we use a context to store the same env vars. Contexts can be accessed by forked prs

@bitwiseguy bitwiseguy marked this pull request as ready for review September 3, 2024 20:08
@bitwiseguy bitwiseguy requested a review from a team as a code owner September 3, 2024 20:08
@bitwiseguy bitwiseguy merged commit 23d6ccb into main Sep 3, 2024
13 checks passed
@bitwiseguy bitwiseguy deleted the ss/circleci-rpc-url-context-2 branch September 3, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants