Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ethernity Testnet #514

Closed
wants to merge 8 commits into from
Closed

Conversation

denis-pingin
Copy link
Contributor

Adding a New Chain

This PR adds Ethernity Testnet to the registry.

Checklist

  • I have declared the chain at the appropriate Superchain Level.
  • I have run just validate <chain-id> locally to ensure all local validation checks pass.
  • I have run just codegen to ensure that the chainlist and other generated files are up-to-date and include my chain.

@sbvegan sbvegan removed the F-do-not-merge Flag: Do Not Merge label Sep 17, 2024
@sbvegan sbvegan assigned Wazabie and unassigned winnsterx Sep 23, 2024
@sbvegan
Copy link
Collaborator

sbvegan commented Sep 25, 2024

Hey @denis-pingin, we pulled the custom gas token address placeholder out of Ethernity Mainnet here: #614 (review). We'll want to do the same for this PR

@Wazabie
Copy link
Contributor

Wazabie commented Oct 2, 2024

Hey @denis-pingin just following up on this, can you manually remove the gas_paying_token field from the sepolia/ethernity.toml file and rerun just codegen so the summary files also have the gas_paying_token field removed?

@parkgunou parkgunou requested review from a team and removed request for a team October 16, 2024 23:32
@sbvegan sbvegan mentioned this pull request Oct 25, 2024
3 tasks
@ImTei
Copy link
Collaborator

ImTei commented Oct 28, 2024

Merged via #660

@ImTei ImTei closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-new-chain-request Meta: New Chain Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants