Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set the status to SIGNED. #358

Closed
wants to merge 1 commit into from

Conversation

Ethnical
Copy link
Contributor

Description

Update the status of base-002-fp-upgrade to SIGNED for now and should be set to EXECUTED after execution.

@Ethnical Ethnical marked this pull request as ready for review October 29, 2024 19:19
@Ethnical Ethnical requested a review from a team as a code owner October 29, 2024 19:19
@Ethnical Ethnical requested a review from mds1 October 29, 2024 22:05
@Ethnical
Copy link
Contributor Author

I will close this PR because this is not necessary and the correct flow to change the status to SIGNED should be only for PSPs runbooks.
From this conversation on discord:
Ah interesting. So SIGNED was intended to be a terminal state for things like presigned pause, where we sign the playbook and don't have any immediate plans to execute. For this kind of playbook (sign + execute around the same time) we typically go straight from READY TO SIGN to EXECUTED. The reason being a "terminal status" matters is because we want to use those to determine which tasks to automatically exceute in CI: #337
Mentioning this issue -> #337

@Ethnical Ethnical closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant