Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _nestedPostCheck to NestedSignFromJson base script #319

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Add _nestedPostCheck to NestedSignFromJson base script #319

merged 2 commits into from
Sep 12, 2024

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Sep 5, 2024 •
edited
Loading

Implemented the _nestedPostCheck function in the NestedSignFromJson base script.

This provides a robust fix to the failed simulation on approval calls.

Keeping in draft until #311 is merged to not break it.

@maurelian maurelian marked this pull request as ready for review September 12, 2024 18:22
@maurelian maurelian requested review from a team as code owners September 12, 2024 18:22
@maurelian maurelian requested a review from mbaxter September 12, 2024 18:22
@maurelian maurelian added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 105348a Sep 12, 2024
12 checks passed
@maurelian maurelian deleted the maur/nestedPostCheck branch September 12, 2024 18:26
@mds1 mds1 mentioned this pull request Sep 27, 2024
Closed
@mds1 mds1 mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 approved these changes

@mbaxter mbaxter Awaiting requested review from mbaxter mbaxter is a code owner automatically assigned from ethereum-optimism/contract-reviewers

Assignees

@mds1 mds1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurelian @mds1