Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop: token standard without data #268

Merged

Conversation

0xParticle
Copy link
Contributor

@0xParticle 0xParticle commented Jul 9, 2024

Description
This PR is a rewrite of 71 removing the data parameter from the sendERC() and relayERC20() functions and corresponding events. The text has been modified accordingly and I added a new section in Future considerations showcasing the cross-chain concatenation flow without using the call in the standard.

The goal of this PR is to open the discussion on whether or not we should include the call optionality as part of the standard.

@0xParticle
Copy link
Contributor Author

0xParticle commented Jul 9, 2024

The main reason we are considering to remove the call is simplicity. It is possible to achieve the same result without adding this feature to the standard, with two separate calls to the L2toL2CrossDomainMessenger. We have been leaning towards simplicity in the standard and we think it makes sense to keep that intuition here as well.

The main issue we can see for the user without the integrated call is the possibility of having message reordering at the sequencer level. This would be a serious issue if and only if the call does not depend on the funds arriving, as otherwise the message would revert but can be replayed later. Notice the integrated call flow also had a large risk when funds where burnt and the call reverted (this can be replayed as well, but if the call was badly formatted for example, funds would be locked).

It would be amazing if there was a way to ensure at the messaging layer that concatenated messages (maybe a new type of message?) get included in the right ordering.

@tynes
Copy link
Contributor

tynes commented Jul 10, 2024

Fire!

@tynes
Copy link
Contributor

tynes commented Jul 10, 2024

Just needs a linting fix then good to go

@tynes tynes merged commit 3282dfc into feat/superchain-token-standard Jul 14, 2024
1 check passed
@tynes tynes deleted the feat/superchain-token-standard-no-data branch July 14, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants