Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo #9874

Merged
merged 2 commits into from
Apr 14, 2024
Merged

chore: fix typo #9874

merged 2 commits into from
Apr 14, 2024

Conversation

brucexc
Copy link
Contributor

@brucexc brucexc commented Mar 15, 2024

Description

Incorrect Method Name in Comments

@brucexc brucexc requested a review from a team as a code owner March 15, 2024 21:15
@brucexc brucexc requested a review from ajsutton March 15, 2024 21:15
Copy link
Contributor

coderabbitai bot commented Mar 15, 2024

Walkthrough

Walkthrough

The update involves renaming a function within the SendState structure from TxMined to TxNotMined to better reflect transactions not successfully mined or reorganized out. Additionally, a typo in a comment in txmgr.go was corrected from "resumbission" to "resubmission," enhancing clarity in the resubmission loop.

Changes

File Change Summary
op-service/txmgr/send_state.go Renamed TxMined to TxNotMined in SendState for clearer transaction status.
op-service/txmgr/txmgr.go Corrected typo in comment from "resumbission" to "resubmission" for clarity.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 2, 2024
@trianglesphere trianglesphere added this pull request to the merge queue Apr 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2024
@github-actions github-actions bot removed the Stale label Apr 3, 2024
@trianglesphere trianglesphere added this pull request to the merge queue Apr 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2024
@trianglesphere trianglesphere added this pull request to the merge queue Apr 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2024
@ajsutton ajsutton added this pull request to the merge queue Apr 14, 2024
Merged via the queue into ethereum-optimism:develop with commit c7ad0eb Apr 14, 2024
70 checks passed
maurelian pushed a commit that referenced this pull request Apr 15, 2024
* chore: fix typo

* chore: fix typo
pcw109550 pushed a commit to testinprod-io/optimism that referenced this pull request Apr 15, 2024
* chore: fix typo

* chore: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants