-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update wd-mon to work for OptimismPortal2 #9334
Conversation
a98844a
to
f90cc64
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #9334 +/- ##
============================================
+ Coverage 27.86% 38.00% +10.14%
============================================
Files 167 38 -129
Lines 7357 2039 -5318
Branches 1271 441 -830
============================================
- Hits 2050 775 -1275
+ Misses 5186 1264 -3922
+ Partials 121 0 -121
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f525a36
to
919f339
Compare
Warning Rate Limit Exceeded@smartcontracts has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 23 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm made one suggestion about an Address typescript type and then happy to approve
919f339
to
c2e9ed4
Compare
Semgrep found 1
This tag is missing an 'integrity' subresource integrity attribute. The 'integrity' attribute allows for the browser to verify that externally hosted files (for example from a CDN) are delivered without unexpected manipulation. Without this attribute, if an attacker can modify the externally hosted resource, this could lead to XSS and other types of attacks. To prevent this, include the base64-encoded cryptographic hash of the resource (file) you’re telling the browser to fetch in the 'integrity' attribute for all externally hosted files. Ignore this finding from missing-integrity.Semgrep found 4 Please create a GitHub ticket for this TODO. Ignore this finding from todos_require_linear. |
Description
Updates wd-mon so that it works properly with OptimismPortal2. Doesn't require any significant functional changes outside of the logic used to pick the starting block number. Used this as a chance to clean up the service and generalize it so it works better with chains other than OP Mainnet.
I've run this locally and it works. New API is a superset of the old API, just added some extra metrics and new options.