Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update wd-mon to work for OptimismPortal2 #9334

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Feb 4, 2024

Description
Updates wd-mon so that it works properly with OptimismPortal2. Doesn't require any significant functional changes outside of the logic used to pick the starting block number. Used this as a chance to clean up the service and generalize it so it works better with chains other than OP Mainnet.

I've run this locally and it works. New API is a superset of the old API, just added some extra metrics and new options.

@smartcontracts smartcontracts force-pushed the sc/wd-mon-fpac branch 2 times, most recently from a98844a to f90cc64 Compare February 4, 2024 06:55
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (88586b7) 27.86% compared to head (c2e9ed4) 38.00%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9334       +/-   ##
============================================
+ Coverage    27.86%   38.00%   +10.14%     
============================================
  Files          167       38      -129     
  Lines         7357     2039     -5318     
  Branches      1271      441      -830     
============================================
- Hits          2050      775     -1275     
+ Misses        5186     1264     -3922     
+ Partials       121        0      -121     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests 26.72% <25.00%> (-0.03%) ⬇️
contracts-bedrock-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests 41.52% <ø> (ø)
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/common-ts/src/base-service/validators.ts 38.46% <25.00%> (-2.45%) ⬇️

... and 129 files with indirect coverage changes

@smartcontracts smartcontracts force-pushed the sc/wd-mon-fpac branch 2 times, most recently from f525a36 to 919f339 Compare February 4, 2024 20:08
@smartcontracts smartcontracts marked this pull request as ready for review February 4, 2024 20:08
@smartcontracts smartcontracts requested review from a team as code owners February 4, 2024 20:08
Copy link
Contributor

coderabbitai bot commented Feb 4, 2024

Warning

Rate Limit Exceeded

@smartcontracts has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 23 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 7b732ea and c2e9ed4.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm made one suggestion about an Address typescript type and then happy to approve

packages/common-ts/src/base-service/validators.ts Outdated Show resolved Hide resolved
packages/chain-mon/src/wd-mon/constants.ts Show resolved Hide resolved
Copy link
Contributor

semgrep-app bot commented Feb 4, 2024

Semgrep found 1 missing-integrity finding:

  • op-node/cmd/stateviz/assets/index.html: L8

This tag is missing an 'integrity' subresource integrity attribute. The 'integrity' attribute allows for the browser to verify that externally hosted files (for example from a CDN) are delivered without unexpected manipulation. Without this attribute, if an attacker can modify the externally hosted resource, this could lead to XSS and other types of attacks. To prevent this, include the base64-encoded cryptographic hash of the resource (file) you’re telling the browser to fetch in the 'integrity' attribute for all externally hosted files.

Ignore this finding from missing-integrity.

Semgrep found 4 todos_require_linear findings:

  • op-node/cmd/stateviz/main.go: L115
  • op-node/cmd/stateviz/assets/main.js: L89, L79, L62

Please create a GitHub ticket for this TODO.

Ignore this finding from todos_require_linear.

@mslipper mslipper added this pull request to the merge queue Feb 4, 2024
Merged via the queue into develop with commit 1ed50c4 Feb 4, 2024
68 checks passed
@mslipper mslipper deleted the sc/wd-mon-fpac branch February 4, 2024 23:20
@github-actions github-actions bot mentioned this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants