op-node,sources: Add Beacon source option to fetch all sidecars

[sebastianst]

Description

Adds option to beacon source to fetch all blob sidecars and filter locally.

This also fixes a possible bug where the returned sidecars where not ordered by the input hashes.

Tests

TBD

Additional context

Needed to fix buggy beacon node endpoints where query filters are not working.

See also sigp/lighthouse#5107

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67dc565) 28.33% compared to head (b0c6764) 0.67%.
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #9151       +/-   ##
===========================================
- Coverage    28.33%   0.67%   -27.66%     
===========================================
  Files          166      87       -79     
  Lines         7289    2208     -5081     
  Branches      1241     506      -735     
===========================================
- Hits          2065      15     -2050     
+ Misses        5103    2193     -2910     
+ Partials       121       0      -121     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	?
common-ts-tests	?
contracts-bedrock-tests	0.67% <ø> (ø)
contracts-ts-tests	?
core-utils-tests	?
sdk-next-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 79 files with indirect coverage changes

[protolambda]

LGTM, one nit; we can break early out of the inner loop

[coderabbitai]

Warning

Rate Limit Exceeded

@sebastianst has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 39 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 172a799 and b0c6764.

Walkthrough

The changes involve updates to a go-based project, primarily focusing on the L1BeaconClient and its configuration. A new flag BeaconFetchAllSidecars has been introduced to handle sidecar fetching due to Beacon nodes issues. This flag affects various components, requiring updates to function calls, configurations, and error handling. Tests are updated to reflect these changes, ensuring the new logic works correctly and error conditions are properly managed.

Changes

File(s)	Change Summary
op-e2e/l1_beacon_client_test.go op-service/sources/l1_beacon_client.go op-service/sources/l1_beacon_client_test.go	Updated NewL1BeaconClient function to accept new config parameter. Improved error handling and response processing. Added test cases for error conditions and sidecar ordering.
op-node/flags/flags.go op-node/node/client.go op-node/node/node.go op-node/service.go	Introduced BeaconFetchAllSidecars flag and incorporated it into the L1BeaconEndpointConfig. Extended interfaces and structs to support the new flag. Updated function calls and variable declarations accordingly.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.