feat[contracts]: enable initiating L2 upgrade via L1 to L2 message #887
Conversation
🦋 Changeset detectedLatest commit: f01dc0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Ahh, nice! I originally had figured that we would do it this way, and agree that this is 100% the way to go if to enable the upgrade to be initiated via an L2 account if desired.
For what it's worth, I think we are 95% of the way there to an OVM_CrossDomainOwnedProxy with this contract. Only update would require replacing the fallback function with a doCall(address _target, bytes memory _data) so that we can call arbitrary targets. Maybe we want the target to be hardcoded in this case, or maybe we just want it as-is to focus on getting stuff merged quickly. Approving under the assumption that that is the case.
smartcontracts
requested review from
annieke,
karlfloersch and
tynes
as code owners
smartcontracts
force-pushed
the
kelvin/chugsplash-owner
branch
from
4fc259f to
f01dc0a
Compare
…thereum-optimism#887) * feat[contracts]: enable initiating L2 upgrade via L1 to L2 message * chore: add changeset
…thereum-optimism#887) * feat[contracts]: enable initiating L2 upgrade via L1 to L2 message * chore: add changeset
Description
Adds a new contract
L2ChugSplashOwnerwhich acts as an authenticated proxy to theL2ChugSplashDeployercontract. I've decided to do it this way because it gives us more options and ends up being simpler to test than #854. Writing this contract made me realize we really should have anCrossDomainOwnablehelper contract (cc: @ben-chain).