op-node: flexible L2 genesis generation #8102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for the `op-node` L2 genesis generation to use either hardhat artifacts or the `.deploy` L1Deployments JSON file that is created by the solidity deployment script. While adding extra logic, this makes genesis generation much easier to be consumed by the solidity scripts. It also sets up the ability to deprecate the need for maintaining hardhat deploy style artifacts. This will allow us to remove a lot of solidity code and remove the need to call `sync()` to generate the artifacts. The artifacts make less sense now, especially since it is planned to have one set of implementation contracts for the entire superchain. There isn't as much of a need to keep around artifacts for many contracts separated by network when they are shared between different L2s.
|
@tynes This should be really helpful but it would be great if we have some documents about using it. |
Codecov Report
@@ Coverage Diff @@
## develop #8102 +/- ##
===========================================
- Coverage 45.48% 39.08% -6.40%
===========================================
Files 171 95 -76
Lines 7214 3006 -4208
Branches 1150 624 -526
===========================================
- Hits 3281 1175 -2106
+ Misses 3810 1754 -2056
+ Partials 123 77 -46
Flags with carried forward coverage won't be shown. Click here to find out more. |
@kaliubuntu0206 I added a description to the source code, we have docs here |
trianglesphere
approved these changes
Nov 9, 2023
We don't have any legacy artifacts at this point left in the monorepo and all new chains should be deployed with the solidity scripts instead of the hardhat deploy scripts. The solidity scripts create modern artifacts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow for the
op-nodeL2 genesis generation to use eitherhardhat artifacts or the
.deployL1Deployments JSON filethat is created by the solidity deployment script. While adding
extra logic, this makes genesis generation much easier to be
consumed by the solidity scripts. It also sets up the ability
to deprecate the need for maintaining hardhat deploy style
artifacts. This will allow us to remove a lot of solidity code
and remove the need to call
sync()to generate the artifacts.The artifacts make less sense now, especially since it is planned
to have one set of implementation contracts for the entire superchain.
There isn't as much of a need to keep around artifacts for many
contracts separated by network when they are shared between
different L2s.