Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: Check withdrawals hash in P2P validation #8035

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

trianglesphere
Copy link
Contributor

Description

Require P2P gossiped blocks to have empty withdrawals. Also clarify the specs around the handling of withdrawals in the op-node.

Tests

Unit tests for this new case

@trianglesphere trianglesphere requested review from a team as code owners November 3, 2023 20:05
@trianglesphere trianglesphere force-pushed the jg/require_empty_withdrawals branch from fe74189 to bae5c11 Compare November 3, 2023 20:10
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #8035 (62a804c) into develop (1d4afbf) will decrease coverage by 5.78%.
Report is 48 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #8035      +/-   ##
===========================================
- Coverage    46.07%   40.30%   -5.78%     
===========================================
  Files          170       94      -76     
  Lines         7121     2913    -4208     
  Branches      1138      612     -526     
===========================================
- Hits          3281     1174    -2107     
+ Misses        3717     1666    -2051     
+ Partials       123       73      -50     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests 40.30% <ø> (ø)
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 76 files with indirect coverage changes

@trianglesphere trianglesphere force-pushed the jg/require_empty_withdrawals branch from bae5c11 to a28d727 Compare November 3, 2023 21:15
@trianglesphere trianglesphere force-pushed the jg/require_empty_withdrawals branch from a28d727 to 62a804c Compare November 7, 2023 00:11
@trianglesphere trianglesphere requested a review from tynes November 7, 2023 00:12
Copy link
Contributor

semgrep-app bot commented Nov 7, 2023

Semgrep found 1 nil-check-after-call finding:

Potential p2pmetrics nil dereference when NewBandwidthCounter is called

Ignore this finding from nil-check-after-call.

@trianglesphere trianglesphere added this pull request to the merge queue Nov 7, 2023
Merged via the queue into develop with commit 6cce372 Nov 7, 2023
62 checks passed
@trianglesphere trianglesphere deleted the jg/require_empty_withdrawals branch November 7, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants