-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ERC20 Factory Storage #6839
Conversation
Can confirm
|
Gas snapshot failing due to wrong version of foundry being used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 💯
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6839 +/- ##
===========================================
- Coverage 44.82% 42.59% -2.23%
===========================================
Files 376 337 -39
Lines 29528 28336 -1192
Branches 1692 1541 -151
===========================================
- Hits 13236 12071 -1165
- Misses 14852 14859 +7
+ Partials 1440 1406 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Updates the
OptimismMintableERC20Factory
to put its bridge in storage. This contract also needed its implementation to be updated to be able to work in a singleton pattern. It was missed during the implementation work, potentially due to it being inside of theuniversal
directory instead of theL1
directory.Includes updates to tests as well as bindings and L2 genesis generation.