Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ERC20 Factory Storage #6839

Merged
merged 8 commits into from
Aug 17, 2023
Merged

feat: ERC20 Factory Storage #6839

merged 8 commits into from
Aug 17, 2023

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Aug 16, 2023

Description

Updates the OptimismMintableERC20Factory to put its bridge in storage. This contract also needed its implementation to be updated to be able to work in a singleton pattern. It was missed during the implementation work, potentially due to it being inside of the universal directory instead of the L1 directory.

Includes updates to tests as well as bindings and L2 genesis generation.

@tynes tynes requested review from a team as code owners August 16, 2023 22:39
@tynes tynes requested review from ajsutton and refcell August 16, 2023 22:39
@tynes
Copy link
Contributor Author

tynes commented Aug 16, 2023

Can confirm check-l2 is correct:

INFO [08-16|22:53:49.393] OptimismMintableERC20Factory             implementation=0xc0D3c0d3C0d3c0d3c0D3c0d3c0D3c0D3c0D30012
INFO [08-16|22:53:49.393] OptimismMintableERC20Factory             BRIDGE=0x4200000000000000000000000000000000000010
INFO [08-16|22:53:49.394] OptimismMintableERC20Factory             bridge=0x4200000000000000000000000000000000000010
INFO [08-16|22:53:49.394] OptimismMintableERC20Factory             _initialized=2
INFO [08-16|22:53:49.395] OptimismMintableERC20Factory             _initializing=false
INFO [08-16|22:53:49.395] OptimismMintableERC20Factory version     version=1.3.0

@tynes
Copy link
Contributor Author

tynes commented Aug 16, 2023

Gas snapshot failing due to wrong version of foundry being used

Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 💯

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #6839 (a8904e7) into develop (ee86052) will decrease coverage by 2.23%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6839      +/-   ##
===========================================
- Coverage    44.82%   42.59%   -2.23%     
===========================================
  Files          376      337      -39     
  Lines        29528    28336    -1192     
  Branches      1692     1541     -151     
===========================================
- Hits         13236    12071    -1165     
- Misses       14852    14859       +7     
+ Partials      1440     1406      -34     
Flag Coverage Δ
bedrock-go-tests 47.84% <100.00%> (-0.01%) ⬇️
cannon-go-tests ?
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests ?
contracts-bedrock-tests ∅ <ø> (∅)
contracts-ts-tests 6.88% <ø> (ø)
core-utils-tests ?
sdk-next-tests 41.75% <ø> (ø)
sdk-tests 41.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
op-chain-ops/genesis/config.go 30.45% <100.00%> (+0.79%) ⬆️
op-chain-ops/immutables/immutables.go 68.80% <100.00%> (ø)

... and 50 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot added the S-on-merge-train Status: This PR is in the merge queue label Aug 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit a1f16b3 into develop Aug 17, 2023
@OptimismBot OptimismBot deleted the feat/factory-storage branch August 17, 2023 01:33
@mergify mergify bot removed the S-on-merge-train Status: This PR is in the merge queue label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants