Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ctb): Fix delete output compiler warning #6813

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Aug 16, 2023

Description

Small chore to fix the compiler warning for the DeleteOutput script in contracts-bedrock by removing the parameter name.

See example output below without this fix:

Screenshot 2023-08-16 at 7 42 12 AM

@refcell refcell added C-chore Category: Code, docs or tooling maintenance M-contracts labels Aug 16, 2023
@refcell refcell requested a review from tynes August 16, 2023 11:46
@refcell refcell self-assigned this Aug 16, 2023
@refcell refcell requested a review from a team as a code owner August 16, 2023 11:46
@refcell refcell added A-pkg-contracts-bedrock Area: packages/contracts-bedrock and removed A-contracts labels Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #6813 (42c3027) into develop (dfcb144) will increase coverage by 0.21%.
Report is 8 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6813      +/-   ##
===========================================
+ Coverage    44.76%   44.98%   +0.21%     
===========================================
  Files          375      342      -33     
  Lines        29474    28618     -856     
  Branches      1692     1541     -151     
===========================================
- Hits         13194    12873     -321     
+ Misses       14838    14303     -535     
  Partials      1442     1442              
Flag Coverage Δ
bedrock-go-tests 47.77% <ø> (-0.01%) ⬇️
cannon-go-tests 64.18% <ø> (ø)
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests ?
contracts-bedrock-tests ∅ <ø> (∅)
contracts-ts-tests 6.88% <ø> (ø)
core-utils-tests ?
sdk-next-tests 41.75% <ø> (ø)
sdk-tests 41.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 34 files with indirect coverage changes

@refcell refcell merged commit bd07e6e into develop Aug 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pkg-contracts-bedrock Area: packages/contracts-bedrock C-chore Category: Code, docs or tooling maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants