Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts-bedrock: slight cleanup + docs #6751

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Aug 11, 2023

Description

Makes it easier to do deployments with a better abstraction. The first step of a deployment is always to do the deployment, then run sync() to parse the forge deploy artifact into a hardhat style artifact. This commit improves the UX of sync()

@tynes tynes requested a review from a team as a code owner August 11, 2023 20:29
@tynes tynes requested a review from maurelian August 11, 2023 20:29
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

⚠️ No Changeset found

Latest commit: 0bc6acb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Makes it easier to do deployments with a better abstraction.
The first step of a deployment is always to do the deployment,
then run `sync()` to parse the forge deploy artifact into a
hardhat style artifact. This commit improves the UX of `sync()`
@refcell refcell force-pushed the fix/deploy-cleanup-docs branch from 0bc6acb to 44c8709 Compare August 15, 2023 21:29
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #6751 (e0b2396) into develop (75904fc) will decrease coverage by 2.23%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6751      +/-   ##
===========================================
- Coverage    44.75%   42.53%   -2.23%     
===========================================
  Files          375      336      -39     
  Lines        29474    28277    -1197     
  Branches      1692     1541     -151     
===========================================
- Hits         13192    12028    -1164     
  Misses       14840    14840              
+ Partials      1442     1409      -33     
Flag Coverage Δ
bedrock-go-tests 47.77% <ø> (+<0.01%) ⬆️
cannon-go-tests ?
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests ?
contracts-bedrock-tests ∅ <ø> (∅)
contracts-ts-tests 6.88% <ø> (ø)
core-utils-tests ?
sdk-next-tests 41.75% <ø> (ø)
sdk-tests 41.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 47 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

This PR has been added to the merge queue, and will be merged soon.

@tynes
Copy link
Contributor Author

tynes commented Aug 16, 2023

ty for fix @refcell <3

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 3783ce2 into develop Aug 16, 2023
@OptimismBot OptimismBot deleted the fix/deploy-cleanup-docs branch August 16, 2023 02:28
@mergify mergify bot removed the on-merge-train label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants