Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add log to record mapping between channel and block #6724

Merged

Conversation

keroro520
Copy link
Contributor

@keroro520 keroro520 commented Aug 11, 2023

This commit adds a new log that prints out the channel ID and corresponding block number whenever a new block is added to a channel. This will help trace and debug the relationship between channels and blocks.

This commit adds a new log that prints out the channel ID and corresponding block number whenever a new block is added to a channel. This will help trace and debug the relationship between channels and blocks.
@keroro520 keroro520 requested a review from a team as a code owner August 11, 2023 11:03
@keroro520 keroro520 requested a review from Inphi August 11, 2023 11:03
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

⚠️ No Changeset found

Latest commit: 0a13095

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Aug 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #6724 (0a13095) into develop (6cc232e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6724      +/-   ##
===========================================
+ Coverage    44.53%   44.56%   +0.02%     
===========================================
  Files          375      375              
  Lines        29522    29524       +2     
  Branches      1688     1688              
===========================================
+ Hits         13148    13157       +9     
+ Misses       14939    14934       -5     
+ Partials      1435     1433       -2     
Flag Coverage Δ
bedrock-go-tests 47.51% <100.00%> (+0.03%) ⬆️
cannon-go-tests 64.19% <ø> (ø)
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests ∅ <ø> (∅)
contracts-ts-tests 6.88% <ø> (ø)
core-utils-tests 44.24% <ø> (ø)
sdk-next-tests 41.97% <ø> (ø)
sdk-tests 41.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
op-batcher/batcher/channel_manager.go 82.35% <100.00%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

@OptimismBot OptimismBot merged commit 896fc1c into ethereum-optimism:develop Aug 11, 2023
@mergify mergify bot removed the on-merge-train label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants