-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: Metrics in the channel bank #6708
Conversation
|
Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review. |
48d4d3c
to
1990b4a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6708 +/- ##
===========================================
+ Coverage 44.77% 47.76% +2.98%
===========================================
Files 375 307 -68
Lines 29474 23293 -6181
Branches 1692 0 -1692
===========================================
- Hits 13198 11126 -2072
+ Misses 14836 11156 -3680
+ Partials 1440 1011 -429
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This adds 3 new metrics to channel bank: 1. New Head Channel Event 2. Channel Timed Out Event 3. Frame Added Event The new channel head event is the most complex. It indicates that there is new channel in the ready position of the channel bank. It does not indicate if the channel is ready to be read from. It is complicated to implement because we have several ways of removing channels which would mean that a new channel becomes the head channel. The channel timeout & frame added events are much simpler. The intention is to make it easier to determine if the head channel in the channel bank is not progressing.
1990b4a
to
c37e68f
Compare
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
This adds 3 new metrics to channel bank:
The new channel head event is the most complex. It indicates that there is new
channel in the ready position of the channel bank. It does not indicate if the
channel is ready to be read from. It is complicated to implement because we
have several ways of removing channels which would mean that a new channel becomes
the head channel.
The channel timeout & frame added events are much simpler.
The intention is to make it easier to determine if the head channel in the channel
bank is not progressing.
Metadata