Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: Metrics in the channel bank #6708

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Aug 10, 2023

Description

This adds 3 new metrics to channel bank:

  1. New Head Channel Event
  2. Channel Timed Out Event
  3. Frame Added Event

The new channel head event is the most complex. It indicates that there is new
channel in the ready position of the channel bank. It does not indicate if the
channel is ready to be read from. It is complicated to implement because we
have several ways of removing channels which would mean that a new channel becomes
the head channel.

The channel timeout & frame added events are much simpler.

The intention is to make it easier to determine if the head channel in the channel
bank is not progressing.

Metadata

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023

⚠️ No Changeset found

Latest commit: 48d4d3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Aug 14, 2023

Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Aug 14, 2023
@trianglesphere trianglesphere force-pushed the jg/channel_bank_metric branch from 48d4d3c to 1990b4a Compare August 14, 2023 19:57
@trianglesphere trianglesphere changed the title WIP: op-node: Metrics in the channel bank op-node: Metrics in the channel bank Aug 14, 2023
@trianglesphere trianglesphere marked this pull request as ready for review August 14, 2023 19:57
@trianglesphere trianglesphere requested review from protolambda and a team as code owners August 14, 2023 19:57
@mergify mergify bot removed the conflict label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #6708 (5f12865) into develop (d3f4ec8) will increase coverage by 2.98%.
The diff coverage is 39.39%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6708      +/-   ##
===========================================
+ Coverage    44.77%   47.76%   +2.98%     
===========================================
  Files          375      307      -68     
  Lines        29474    23293    -6181     
  Branches      1692        0    -1692     
===========================================
- Hits         13198    11126    -2072     
+ Misses       14836    11156    -3680     
+ Partials      1440     1011     -429     
Flag Coverage Δ
bedrock-go-tests 47.76% <39.39%> (-0.04%) ⬇️
cannon-go-tests ?
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests ∅ <ø> (∅)
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
op-node/rollup/derive/pipeline.go 0.00% <0.00%> (ø)
op-node/rollup/driver/driver.go 0.00% <ø> (ø)
op-node/testutils/metrics.go 4.00% <0.00%> (-0.55%) ⬇️
op-node/metrics/metrics.go 3.49% <15.38%> (+0.30%) ⬆️
op-node/rollup/derive/channel_bank.go 70.37% <68.75%> (+0.15%) ⬆️

... and 77 files with indirect coverage changes

This adds 3 new metrics to channel bank:
1. New Head Channel Event
2. Channel Timed Out Event
3. Frame Added Event

The new channel head event is the most complex. It indicates that there is new
channel in the ready position of the channel bank. It does not indicate if the
channel is ready to be read from. It is complicated to implement because we
have several ways of removing channels which would mean that a new channel becomes
the head channel.

The channel timeout & frame added events are much simpler.

The intention is to make it easier to determine if the head channel in the channel
bank is not progressing.
@trianglesphere trianglesphere force-pushed the jg/channel_bank_metric branch from 1990b4a to c37e68f Compare August 16, 2023 16:37
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 6adc454 into develop Aug 16, 2023
@OptimismBot OptimismBot deleted the jg/channel_bank_metric branch August 16, 2023 20:42
@mergify mergify bot removed the on-merge-train label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants