Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename deployments filenames to remove colons #662

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

snario
Copy link
Contributor

@snario snario commented Apr 27, 2021

Temporarily addresses #558 until we do another deployment.

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2021

🦋 Changeset detected

Latest commit: f6776a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@snario snario force-pushed the liam/no-colons branch 2 times, most recently from 37a838b to 32e7985 Compare April 27, 2021 23:12
@snario snario requested review from tynes and removed request for ben-chain and maurelian April 28, 2021 00:36
@tynes
Copy link
Contributor

tynes commented Apr 28, 2021

This is important for @smartcontracts to review as this touches code that he has written. Ideally the files that are generated no longer have colons in them. There is a mapping between the name of the contract and the name that goes in the AddressManager so for consistency we should rename the contracts in the address manager as well. That could be done in another PR but needs to happen before another deployment

Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it's fine to merge this as a temporary fix since we have that other issue written up.

@snario snario merged commit f1f5bf2 into master Apr 28, 2021
@snario snario deleted the liam/no-colons branch April 28, 2021 20:20
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
…imism#662)

* refactor: rename deployments filenames to remove colons

* build: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants