Null-Checking for bytecode in solc-transpiler #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlfloersch
reviewed
Apr 2, 2020
There was a problem hiding this comment.
Was your only material change adding the if statement? If so I think this is probably good to go once you change it to use continue, but just @willmeister or @ben-chain y'all should check my work that the if statement doesn't break anything nuanced.
| contractName | ||
| ) | ||
| log.debug(`Transpiled contract ${contractName}.`) | ||
| if (!!contractJson && !!contractJson.evm && !!contractJson.evm.bytecode && !!contractJson.evm.deployedBytecode) { |
There was a problem hiding this comment.
Probably cleaner to replace with an if(...) continue instead of a big if statement wrapper.
willmeister
pushed a commit
that referenced
this pull request
Apr 2, 2020
* transpiler null-checking bytecode * lint, use continue in transpiler
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
protolambda
pushed a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
keroro520
pushed a commit
to keroro520/optimism
that referenced
this pull request
Oct 20, 2023
…thereum-optimism#66) * feature(contracts-bedrock): add verify.ts for verifying any contract * add .env description * --compiler-version * update env example --------- Co-authored-by: Welkin <[email protected]>
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
* chore: rename isthmus to interop on solidity files * chore: rename test file * chore: update contracts versions (#66)
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* chore: rename isthmus to interop on solidity files * chore: rename test file * chore: update contracts versions (ethereum-optimism#66)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When, for example, we transpile an interface, we will use
solc.compile, which will output an empty bytecode and null deployedBytecode object. We shouldn't be trying to transpile non-existent bytecodeContributing Agreement