Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(indexer): Add indexer-refresh to makefile #5947

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Conversation

roninjin10
Copy link
Contributor

  • build indexer-referesh with make indexer-refresh

@roninjin10 roninjin10 requested a review from a team as a code owner June 9, 2023 05:37
@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

⚠️ No Changeset found

Latest commit: 1fc30f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the A-indexer Area: indexer label Jun 9, 2023
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Jun 9, 2023

Semgrep found 1 use-tls finding:

  • indexer/api/api.go: L109

Found an HTTP server without TLS. Use 'http.ListenAndServeTLS' instead. See https://golang.org/pkg/net/http/#ListenAndServeTLS for more information.

Ignore this finding from use-tls.

Copy link
Contributor

@hamdiallam hamdiallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw you can also use go run to avoid the binaries from being generated

@roninjin10
Copy link
Contributor Author

yup I usuually use go run myself. This is needed for the docker build to work

@semgrep-app
Copy link
Contributor

semgrep-app bot commented Jun 9, 2023

Semgrep found 12 todos_require_linear findings:

  • packages/data-transport-layer/src/services/l1-ingestion/service.ts: L167
  • packages/data-transport-layer/src/utils/contracts.ts: L75
  • packages/data-transport-layer/src/db/simple-db.ts: L10, L37
  • packages/data-transport-layer/src/services/main/service.ts: L121
  • packages/data-transport-layer/src/services/server/service.ts: L138, L226, L227, L228
  • packages/data-transport-layer/src/services/l1-ingestion/handlers/sequencer-batch-appended.ts: L34, L88
  • packages/data-transport-layer/src/utils/validation.ts: L41

Please create a Linear ticket for this TODO.

Ignore this finding from todos_require_linear.

Base automatically changed from willc/healthz to develop June 10, 2023 01:41
@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2023

This PR has been added to the merge queue, and will be merged soon.

@netlify
Copy link

netlify bot commented Jun 10, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 1fc30f8
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6483d50a696f6b0008d15ed7

@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 57855e8 into develop Jun 10, 2023
@OptimismBot OptimismBot deleted the willc/makefile branch June 10, 2023 01:47
@mergify mergify bot removed the on-merge-train label Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-indexer Area: indexer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants