Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: withdrawal gas limit #5501

Merged
merged 5 commits into from
Apr 24, 2023
Merged

fix: withdrawal gas limit #5501

merged 5 commits into from
Apr 24, 2023

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Apr 19, 2023

Description

Updates the gas limit in the migrated withdrawals codepath
to ensure that enough gas is used. This is required after #5470
is merged

Tests

There is test coverage here that prevents a regression. We will need to run this tooling as part of the migration rehearsals to be super sure.

Closes CLI-3856

@tynes tynes requested review from a team as code owners April 19, 2023 22:19
@tynes tynes requested review from Inphi and nickbalestra April 19, 2023 22:19
@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

🦋 Changeset detected

Latest commit: afc2ab8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@eth-optimism/sdk Patch
@eth-optimism/chain-mon Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify mergify bot added the sdk label Apr 19, 2023
@mergify mergify bot requested a review from roninjin10 April 19, 2023 22:19
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for opstack-docs ready!

Name Link
🔨 Latest commit afc2ab8
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6446c304aa09aa0008c1cb2a
😎 Deploy Preview https://deploy-preview-5501--opstack-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tynes tynes changed the title Fix/withdrawal gas limit fix: withdrawal gas limit Apr 19, 2023
Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving sdk changes to unblock

tynes and others added 4 commits April 24, 2023 10:55
@tynes tynes force-pushed the fix/withdrawal-gas-limit branch from 47b0946 to c9ac7a6 Compare April 24, 2023 17:56
@OptimismBot OptimismBot merged commit 090644a into develop Apr 24, 2023
@OptimismBot OptimismBot deleted the fix/withdrawal-gas-limit branch April 24, 2023 18:12
@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants