Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-node/doc: Document op-batcher & op-proposer metrics #5406

Merged
merged 4 commits into from
Apr 13, 2023
Merged

op-node/doc: Document op-batcher & op-proposer metrics #5406

merged 4 commits into from
Apr 13, 2023

Conversation

trianglesphere
Copy link
Contributor

Description

This extends the metrics doc tool to include op-batcher & op-proposer metrics.

Metadata

@trianglesphere trianglesphere requested a review from a team as a code owner April 10, 2023 23:40
@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2c56f51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 10, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 2c56f51
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64385a66882a4a0008769083

@trianglesphere trianglesphere marked this pull request as draft April 10, 2023 23:40
@trianglesphere trianglesphere removed the request for review from sebastianst April 10, 2023 23:40
@trianglesphere trianglesphere marked this pull request as ready for review April 10, 2023 23:43
protolambda
protolambda requested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it as sub-command to the batcher and proposer CLI commands instead? That way we keep the codebases nicely separated.

op-node/Dockerfile Outdated Show resolved Hide resolved
@trianglesphere
Copy link
Contributor Author

Can you add it as sub-command to the batcher and proposer CLI commands instead?

Done

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 3c052f2 into develop Apr 13, 2023
@OptimismBot OptimismBot deleted the jg/metrics_docs branch April 13, 2023 20:01
@mergify mergify bot removed the on-merge-train label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

@tynes tynes tynes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trianglesphere @tynes @protolambda @OptimismBot