Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making all base yarn actions act on all packages including integration tests #45

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

willmeister
Copy link

Description

Before integration tests were not included in yarn [clean | build | test | fix | lint | all]. This PR makes it so that they are, providing isolated core vs integration test tasks where necessary.

Contributing Agreement

Copy link

@masonforest masonforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@willmeister willmeister merged commit b44efe3 into master Mar 19, 2020
@willmeister willmeister deleted the include_test_packages_in_bulk_actions branch March 19, 2020 16:28
gakonst added a commit that referenced this pull request Apr 12, 2021
* feat(l2geth): sequencer fee pricing

ethereum-optimism/go-ethereum#273
ethereum-optimism/go-ethereum#306
ethereum-optimism/go-ethereum#305

* test(l1-l2-comms): fund l2 address before starting the test

* test(rpc): ensure that fee paid grows with data size

* test: add helper class for instantiation optimistic envs

* refactor: use the env container for l1<>l2 tests

* refactor: use the env container for queue ingestion and proxy tests

* fix(erc20-test): take fee payments into account

* refactor: use the env container for fee payment tests

* refactor: use the env container for native eth tests
InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021
* feat(l2geth): sequencer fee pricing

ethereum-optimism/go-ethereum#273
ethereum-optimism/go-ethereum#306
ethereum-optimism/go-ethereum#305

* test(l1-l2-comms): fund l2 address before starting the test

* test(rpc): ensure that fee paid grows with data size

* test: add helper class for instantiation optimistic envs

* refactor: use the env container for l1<>l2 tests

* refactor: use the env container for queue ingestion and proxy tests

* fix(erc20-test): take fee payments into account

* refactor: use the env container for fee payment tests

* refactor: use the env container for native eth tests
@github-actions github-actions bot mentioned this pull request Sep 20, 2022
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 12, 2024
* test: add L2 standard bridge interop unit tests (#13)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: unit tests fixes

* fix: super to legacy tests failing

* fix: mock and expect mint and burn

* fix: add generic factory interface (#14)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert (#17)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert

* fix: use only a public function for create3

* feat: rollback interop factory, modify legacy one

* fix: delete local token return variable

* fix: PR fixes

* feat: add superchain erc20 factory implementation (#23)

* feat: add superchain erc20 factory implementation

* fix: remove createX comments

* test: add superchain erc20 factory tests (#25)

* test: add superchain erc20 factory tests

* test: add erc20 asserts

* test: fix expect emit

* fix: remove comments

* feat: add constructor to superchain ERC20 beacon (#34)

* test: remove factory predeploy etch

----------

Co-authored-by: 0xng <[email protected]>
Co-authored-by: 0xParticle <[email protected]>
Co-authored-by: gotzenx <[email protected]>

* fix: set an arbitrary address for superchain erc20 impl

* fix: deploy a proxy for the beacon on genesis (#45)


---------

Co-authored-by: 0xng <[email protected]>

* fix: conflicts and imports

* fix: interfaces

* chore: add .testdata

* fix: adding back .testdata to gitignore

* fix: new conflicts from ci improvements

---------

Co-authored-by: 0xng <[email protected]>
Co-authored-by: 0xParticle <[email protected]>
Co-authored-by: gotzenx <[email protected]>
Co-authored-by: Disco <[email protected]>
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
* test: add L2 standard bridge interop unit tests (ethereum-optimism#13)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: unit tests fixes

* fix: super to legacy tests failing

* fix: mock and expect mint and burn

* fix: add generic factory interface (ethereum-optimism#14)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert (ethereum-optimism#17)

* test: add L2 standard bridge interop unit tests

* fix: add tests natspec

* fix: add generic factory interface

* feat: modify OptimismMintableERC20Factory for convert

* fix: use only a public function for create3

* feat: rollback interop factory, modify legacy one

* fix: delete local token return variable

* fix: PR fixes

* feat: add superchain erc20 factory implementation (ethereum-optimism#23)

* feat: add superchain erc20 factory implementation

* fix: remove createX comments

* test: add superchain erc20 factory tests (ethereum-optimism#25)

* test: add superchain erc20 factory tests

* test: add erc20 asserts

* test: fix expect emit

* fix: remove comments

* feat: add constructor to superchain ERC20 beacon (ethereum-optimism#34)

* test: remove factory predeploy etch

----------

Co-authored-by: 0xng <[email protected]>
Co-authored-by: 0xParticle <[email protected]>
Co-authored-by: gotzenx <[email protected]>

* fix: set an arbitrary address for superchain erc20 impl

* fix: deploy a proxy for the beacon on genesis (ethereum-optimism#45)


---------

Co-authored-by: 0xng <[email protected]>

* fix: conflicts and imports

* fix: interfaces

* chore: add .testdata

* fix: adding back .testdata to gitignore

* fix: new conflicts from ci improvements

---------

Co-authored-by: 0xng <[email protected]>
Co-authored-by: 0xParticle <[email protected]>
Co-authored-by: gotzenx <[email protected]>
Co-authored-by: Disco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants