Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make full node use timestamp #22

Merged
merged 7 commits into from
Feb 26, 2020
Merged

Make full node use timestamp #22

merged 7 commits into from
Feb 26, 2020

Conversation

willmeister
Copy link

Description

Makes the full node use current timestamp. Also adds the ability to run the full node in test mode to allow configuration of context, such as timestamp.

Metadata

Fixes

Contributing Agreement

karlfloersch
karlfloersch approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! My biggest bit of feedback is we could seriously consider trying to follow ganache-core's timestamp-related RPC methods more closely. That would mean that we don't have the ability to clear a timestamp. Or instead of adopting exactly Ganache's methods, we could just add a evm_increaseTime RPC method anyway so that we don't break someone's test which relies on that kind of call.

Other than that, everything looks great though!

packages/rollup-full-node/src/app/test-handler.ts Outdated Show resolved Hide resolved
packages/rollup-full-node/src/types/handler.ts Outdated Show resolved Hide resolved
@willmeister willmeister merged commit 4bf0c7e into master Feb 26, 2020
@willmeister willmeister deleted the YAS-166/UseTimestampInFullnode branch February 26, 2020 20:34
gakonst added a commit that referenced this pull request Apr 12, 2021
@gakonst
ci: only run the paths that change (#22)
48db9f8
snario pushed a commit that referenced this pull request Apr 14, 2021
@karlfloersch
Add verify transaction (#22)
5026308 
* WIP queue element

* Add verify transaction for queue txs

* Add verifyTransaction(..) except witness
InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021
@gakonst
ci: only run the paths that change (#22)
4fa277c
keroro520 pushed a commit to keroro520/optimism that referenced this pull request May 18, 2023
@s7v7nislands
Merge pull request ethereum-optimism#22 from node-real/squash
c8b9d74 
update to optimism v1.0.3
protolambda pushed a commit that referenced this pull request Jun 16, 2023
@geohot
Merge pull request #22 from snario/liam/typo
f192e77 
Fix typo in log statement
max-sanchez added a commit to hemilabs/optimism that referenced this pull request Apr 16, 2024
@max-sanchez
Squashed 'heminetwork/' changes from b3993a073..88047e707
690ee85 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (ethereum-optimism#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (ethereum-optimism#40)
a5e689493 make: automate copyright headers (ethereum-optimism#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (ethereum-optimism#33)
1be4df2a3 Use 'errors.Is' to compare errors (ethereum-optimism#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (ethereum-optimism#36)
c5b0fea01 electrumx: add connection reuse and pooling (ethereum-optimism#26)
cfc1293e9 Update README.md (ethereum-optimism#29)
8896259f0 retry mine keystone on failure (ethereum-optimism#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes ethereum-optimism#13) (ethereum-optimism#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (ethereum-optimism#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (ethereum-optimism#16)
ac3b7eacb docker: update golang image to v1.22.1 (ethereum-optimism#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (ethereum-optimism#24)
d450b787a Network test start height + no panic (ethereum-optimism#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (ethereum-optimism#19)
bfd3b1dc0 make: add -local flag to goimports (ethereum-optimism#9)
e0e8964fc Move internal error into protocol package (ethereum-optimism#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92 pushed a commit to hemilabs/optimism that referenced this pull request Apr 17, 2024
@max-sanchez @ClaytonNorthey92
Squashed 'heminetwork/' changes from b3993a073..88047e707
b6b1308 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (ethereum-optimism#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (ethereum-optimism#40)
a5e689493 make: automate copyright headers (ethereum-optimism#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (ethereum-optimism#33)
1be4df2a3 Use 'errors.Is' to compare errors (ethereum-optimism#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (ethereum-optimism#36)
c5b0fea01 electrumx: add connection reuse and pooling (ethereum-optimism#26)
cfc1293e9 Update README.md (ethereum-optimism#29)
8896259f0 retry mine keystone on failure (ethereum-optimism#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes ethereum-optimism#13) (ethereum-optimism#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (ethereum-optimism#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (ethereum-optimism#16)
ac3b7eacb docker: update golang image to v1.22.1 (ethereum-optimism#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (ethereum-optimism#24)
d450b787a Network test start height + no panic (ethereum-optimism#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (ethereum-optimism#19)
bfd3b1dc0 make: add -local flag to goimports (ethereum-optimism#9)
e0e8964fc Move internal error into protocol package (ethereum-optimism#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
therealbytes added a commit to therealbytes/optimism that referenced this pull request May 17, 2024
@therealbytes
feat: set registry gas costs (ethereum-optimism#22)
7d24f80
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
@SebastianElvis
chore: fix codec for new modules (ethereum-optimism#22)
ec0ad79 
* init

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlfloersch karlfloersch karlfloersch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willmeister @karlfloersch