op-chain-ops/ecotone-scalar: prefer .FillBytes() to .Bytes() and copy
#13472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter can result in an error if the number is less than 32 bytes in length (it gets padded incorrectly).
geoknee
changed the title
.FillBytes() to .Bytes() and copy
geoknee
commented
Dec 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13472 +/- ##
===========================================
- Coverage 47.59% 43.02% -4.58%
===========================================
Files 943 775 -168
Lines 78827 69304 -9523
Branches 803 0 -803
===========================================
- Hits 37515 29815 -7700
+ Misses 38509 36955 -1554
+ Partials 2803 2534 -269
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sebastianst
reviewed
Dec 19, 2024
geoknee
commented
Dec 19, 2024
geoknee
commented
Dec 19, 2024
sebastianst
approved these changes
Dec 19, 2024
sebastianst
reviewed
Dec 19, 2024
geoknee
added a commit
that referenced
this pull request
Dec 20, 2024
…`copy` (#13472) * prefer .FillBytes() to .Bytes() and copy The latter can result in an error if the number is less than 32 bytes in length (it gets padded incorrectly). * add tests * output to JSON * add test case for OPM * tidy up * use const in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter can result in an error if
scalaris less than 32 bytes in length (it gets padded incorrectly). A common value in use in the wild isscalar=684000-- I've added a test case for this which fails with the existing implementation but passed with the fix.After this is approved, we should cherry pick it on to #13412.
TODO