Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: coverage in mainline CI #13342

Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat: coverage in mainline CI #13342

merged 1 commit into from
Dec 11, 2024

Conversation

smartcontracts
Copy link
Contributor

Adds converage to mainline CI.

@smartcontracts smartcontracts force-pushed the sc/coverage-2 branch 4 times, most recently from 4395e15 to fce0c16 Compare December 10, 2024 21:26
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.02%. Comparing base (6cfe76f) to head (1d088eb).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13342      +/-   ##
===========================================
- Coverage    47.37%   47.02%   -0.35%     
===========================================
  Files          939      936       -3     
  Lines        78465    78078     -387     
  Branches       849      796      -53     
===========================================
- Hits         37171    36718     -453     
- Misses       38517    38635     +118     
+ Partials      2777     2725      -52     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (ø)
cannon-go-tests-64 56.72% <ø> (ø)
contracts-bedrock-tests 89.14% <ø> (-1.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 39 files with indirect coverage changes

@smartcontracts smartcontracts marked this pull request as ready for review December 10, 2024 21:43
@smartcontracts smartcontracts requested review from a team as code owners December 10, 2024 21:43
codecov.yml Outdated Show resolved Hide resolved
Moves code coverage for smart contracts into mainline ci. CI will
now reject PRs that do not have 100% patch coverage.
@tynes tynes added this pull request to the merge queue Dec 11, 2024
Merged via the queue into develop with commit a055e9f Dec 11, 2024
42 checks passed
@tynes tynes deleted the sc/coverage-2 branch December 11, 2024 14:20
sigma pushed a commit that referenced this pull request Dec 19, 2024
Moves code coverage for smart contracts into mainline ci. CI will
now reject PRs that do not have 100% patch coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants