rollup-client: Increase call timeouts in CI #12561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the op-service/client package a fair bit to ensure config options are more consistently applied.
mslipper
approved these changes
Oct 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Refactors the op-service/client package a fair bit to ensure config options are more consistently applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix timeouts in CI when requesting output roots via the RollupClient by increasing the timeouts. The CI boxes can be under a lot of load resulting in surprisingly long delays to respond.
Refactors the op-service/client package a fair bit to ensure config options are more consistently applied and the timeouts can be configured.
Switching
DialRollupClientWithTimeoutto use the dialing code fromNewRPCwhich supports passing through options to configure the timeout but otherwise seems to be duplicated code.