Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-program: Verify prestate reproducibility against releases.json #12538

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Oct 21, 2024

Description

Modifies the op-program prestates reproducibility job to automatically build all op-program tags and compare the results against releases.json which is used by superchain-registry. This will ensure the two files stay in sync.

Also reviewed the op-program releases that have been submitted to governance and removed the governanceApproved flag from some which were never deployed to op-mainnet and not submitted in governance proposals.

The build-prestates.sh script now creates a JSON file that lists the version and hash of each built prestate.

@ajsutton ajsutton changed the title op-program: Create a JSON file that records the tags each prestate was built from op-program: Verify prestate reproducibility against releases.json Oct 22, 2024
@ajsutton
Copy link
Contributor Author

As part of this I did some historical digging so if anyone winds up here wondering why certain releases were marked as not governance approved...

The three governance approved releases currently are:
1.0.0 - initial fault proofs release
1.2.0 - Fjord
1.3.1 - Granite
which are the only thee prestates used in any games on op-mainnet

op-sepolia has used four prestates:
0.2.0 (probably fault proof alpha chad)
0.3.1/1.0.0 (same commit - likely was 0.3.1 when deployed to sepolia and then tagged as the 1.0.0 release for op-mainnet)
1.1.0 (problaby Fjord and likely should have been an rc with the final release only tagged for mainnet)
1.3.0-rc.3 (Granite)

the devnet has also used four:
0.3.0 (I think this was the initial fault proof release and we then found a bug and did a second upgrade - we didn't release alpha chad to devnet as it wasn't integrated with the OptimismPortal could be deployed straight to op-sepolia without any risk)
0.3.1/1.0.0 (initial fault proof release)
1.1.0 (probably Fjord and should have been an RC)
1.3.0-rc.2

… tags

Generates a versions.json to record which prestate came from each tag and compares it to the releases.json.
Adds a couple of releases missed from releases.json and removes governanceApproved from some releases which were not deployed to op-mainnet or submitted to governance.
@Inphi Inphi added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@ajsutton ajsutton added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit bb6de07 Oct 22, 2024
51 checks passed
@ajsutton ajsutton deleted the aj/record-versions branch October 22, 2024 22:48
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
… tags (ethereum-optimism#12538)

Generates a versions.json to record which prestate came from each tag and compares it to the releases.json.
Adds a couple of releases missed from releases.json and removes governanceApproved from some releases which were not deployed to op-mainnet or submitted to governance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants