Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cross domain message context function #12477

Merged
merged 36 commits into from
Oct 17, 2024
Merged

feat: add cross domain message context function #12477

merged 36 commits into from
Oct 17, 2024

Conversation

0xDiscotech
Copy link
Contributor

@0xDiscotech 0xDiscotech commented Oct 15, 2024 •
edited by gotzenx
Loading

Description

Now crossDomainMessageContext() the cross domain sender and source are returned both at once, to avoid having to do 2 different calls in order to get those values.

Tests

  • Add L2ToL2CrossDomainMessenger tests for the crossDomainMessageContext() function
  • Update the SuperchainTokenBridge mocked calls on the tests, since it now calls the crossDomainMessageContext() function

Metadata

CLOSES: #12485

Addresses #12321 (comment)

Additional Context
The SuperchainWETH sendERC20() and relayERC20 functions weren't modified to call crossDomainContext() because they will be removed on a subsequent PR

agusduha and others added 30 commits September 25, 2024 15:20
@agusduha
feat: add superchain erc20 bridge (#61)
ae024a5 
* feat: add superchain erc20 bridge

* fix: interfaces and versions
@0xDiscotech
refactor: optimism superchain erc20 redesign (#62)
2a22161 
* refactor: use oz upgradeable erc20 as dependency

* chore: update interfaces

* fix: tests based on changes

* refactor: remove op as dependency

* feat: add check for supererc20 bridge on modifier

* chore: update tests and interfaces

* chore: update stack vars name on test

* chore: remove empty gitmodules file

* chore: update superchain weth errors
@agusduha
test: add superchain erc20 bridge tests (#65)
6aaf905 
* test: add superchain erc20 bridge tests

* test: add optimism superchain erc20 beacon tests

* test: remove unnecessary test

* test: tests fixes

* test: tests fixes
@0xDiscotech @agusduha
chore: update missing bridge on natspec (#69)
11fda67 
* chore: update missing bridge on natspec

* fix: natspecs

---------

Co-authored-by: agusduha <[email protected]>
@agusduha
fix: remove superchain erc20 base (#70)
7a69a7e
@0xDiscotech @agusduha
refactor: update isuperchainweth (#71)
07c9c77 
---------

Co-authored-by: agusduha <[email protected]>
@agusduha @0xDiscotech
feat: rename mint/burn and add SuperchainERC20 (#74)
d9bdad1 
* refactor: rename mint and burn functions on superchain erc20

* chore: rename optimism superchain erc20 to superchain erc20

* feat: create optimism superchain erc20 contract

* chore: update natspec and errors

* fix: superchain erc20 tests

* refactor: make superchain erc20 abstract

* refactor: move storage and erc20 metadata functions to implementation

* chore: update interfaces

* chore: update superchain erc20 events

* fix: tests

* fix: natspecs

* fix: add semmver lock and snapshots

* fix: remove unused imports

* fix: natspecs

---------

Co-authored-by: 0xDiscotech <[email protected]>
@agusduha
fix: refactor zero check (#76)
2e507b2
@agusduha
Merge branch 'develop' into fix/redesign-merge-conflicts
7fcaf6c
@agusduha
fix: pre pr
619f23c
@agusduha
Merge pull request #77 from defi-wonderland/fix/redesign-merge-conflicts
1981789 
fix: update redesign with dev
@agusduha
fix: semver natspec check failure (#79)
ae019b8 
* fix: semver natspec check failure

* fix: ignore mock contracts in semver natspec script

* fix: error message
@agusduha
feat: add crosschain erc20 interface (#80)
a5aca61 
* feat: add crosschain erc20 interface

* fix: refactor interfaces
@agusduha
fix: superchain bridge natspec (#83)
83757ea
@agusduha @0xng
@0xParticle @gotzenx
fix: superchain weth natspec (#84)
904a0ce 
Co-authored-by: 0xng <[email protected]>
Co-authored-by: 0xParticle <[email protected]>
Co-authored-by: gotzenx <[email protected]>
@agusduha
fix: stop inheriting superchain interfaces (#85)
3ebb1d1 
* fix: stop inheriting superchain interfaces

* fix: move events and erros into the implementation

* fix: make superchainERC20 inherits from crosschainERC20
@agusduha
fix: superchain bridge rename (#86)
1b4317e
@agusduha
fix: fee vault compiler error (#87)
10038c3
@agusduha
Merge branch 'develop' into fix/crosschain-merge-conflicts
9f49b43
@agusduha
fix: remove unused imports
ab1e074
@agusduha
Merge pull request #88 from defi-wonderland/fix/crosschain-merge-conf…
a79bf4e 
…licts

fix: crosschain merge conflicts
@agusduha
fix: refactor common errors (#90)
af9694e 
* fix: refactor common errors

* fix: remove unused version
@0xDiscotech
feat: add cross domain context function
eccf283
@agusduha
fix: reuse unauthorized error (#92)
6c46f9b
@agusduha
Merge branch 'develop' into fix/superchain-erc20-factory-merge-conflicts
736adf3
@agusduha
fix: superchain erc20 factory conflicts
061b1ff
@agusduha
Merge pull request #93 from defi-wonderland/fix/superchain-erc20-fact…
97fb300 
…ory-merge-conflicts

fix: superchain erc20 factory merge conflicts
@agusduha
fix: rename crosschain functions (#94)
71389b6
@0xDiscotech
Merge branch 'sc-feat/crosschain-erc20' into feat/context-function
05de757
@0xDiscotech
chore: run pre-pr
f11893e
@maurelian maurelian added this pull request to the merge queue Oct 17, 2024
Merged via the queue into ethereum-optimism:develop with commit 71ca0f1 Oct 17, 2024
47 checks passed
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@0xDiscotech @agusduha
@0xng @0xParticle @gotzenx @samlaf
feat: add cross domain message context function (ethereum-optimism#12477
7a77b03 
)

* feat: add superchain erc20 bridge (ethereum-optimism#61)

* feat: add superchain erc20 bridge

* fix: interfaces and versions

* refactor: optimism superchain erc20 redesign (ethereum-optimism#62)

* refactor: use oz upgradeable erc20 as dependency

* chore: update interfaces

* fix: tests based on changes

* refactor: remove op as dependency

* feat: add check for supererc20 bridge on modifier

* chore: update tests and interfaces

* chore: update stack vars name on test

* chore: remove empty gitmodules file

* chore: update superchain weth errors

* test: add superchain erc20 bridge tests (ethereum-optimism#65)

* test: add superchain erc20 bridge tests

* test: add optimism superchain erc20 beacon tests

* test: remove unnecessary test

* test: tests fixes

* test: tests fixes

* chore: update missing bridge on natspec (ethereum-optimism#69)

* chore: update missing bridge on natspec

* fix: natspecs

---------

Co-authored-by: agusduha <[email protected]>

* fix: remove superchain erc20 base (ethereum-optimism#70)

* refactor: update isuperchainweth (ethereum-optimism#71)


---------

Co-authored-by: agusduha <[email protected]>

* feat: rename mint/burn and add SuperchainERC20 (ethereum-optimism#74)

* refactor: rename mint and burn functions on superchain erc20

* chore: rename optimism superchain erc20 to superchain erc20

* feat: create optimism superchain erc20 contract

* chore: update natspec and errors

* fix: superchain erc20 tests

* refactor: make superchain erc20 abstract

* refactor: move storage and erc20 metadata functions to implementation

* chore: update interfaces

* chore: update superchain erc20 events

* fix: tests

* fix: natspecs

* fix: add semmver lock and snapshots

* fix: remove unused imports

* fix: natspecs

---------

Co-authored-by: 0xDiscotech <[email protected]>

* fix: refactor zero check (ethereum-optimism#76)

* fix: pre pr

* fix: semver natspec check failure (ethereum-optimism#79)

* fix: semver natspec check failure

* fix: ignore mock contracts in semver natspec script

* fix: error message

* feat: add crosschain erc20 interface (ethereum-optimism#80)

* feat: add crosschain erc20 interface

* fix: refactor interfaces

* fix: superchain bridge natspec (ethereum-optimism#83)

* fix: superchain weth natspec (ethereum-optimism#84)

Co-authored-by: 0xng <[email protected]>
Co-authored-by: 0xParticle <[email protected]>
Co-authored-by: gotzenx <[email protected]>

* fix: stop inheriting superchain interfaces (ethereum-optimism#85)

* fix: stop inheriting superchain interfaces

* fix: move events and erros into the implementation

* fix: make superchainERC20 inherits from crosschainERC20

* fix: superchain bridge rename (ethereum-optimism#86)

* fix: fee vault compiler error (ethereum-optimism#87)

* fix: remove unused imports

* fix: refactor common errors (ethereum-optimism#90)

* fix: refactor common errors

* fix: remove unused version

* feat: add cross domain context function

* fix: reuse unauthorized error (ethereum-optimism#92)

* fix: superchain erc20 factory conflicts

* fix: rename crosschain functions (ethereum-optimism#94)

* chore: run pre-pr

* chore: run pre-pr

* fix: mocked calls on tests

* feat: add cross domain message context function (ethereum-optimism#98)


----
Co-Authored-by: AgusDuha <[email protected]>

---------

Co-authored-by: AgusDuha <[email protected]>
Co-authored-by: agusduha <[email protected]>
Co-authored-by: 0xng <[email protected]>
Co-authored-by: 0xParticle <[email protected]>
Co-authored-by: gotzenx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurelian maurelian maurelian approved these changes

@mds1 mds1 Awaiting requested review from mds1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

L2toL2CDM new context function
3 participants
@0xDiscotech @maurelian @agusduha