op-challenger: Introduce --prestates-url to specify prestates source for all game types at once #12440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
Inphi
approved these changes
Oct 15, 2024
…for all game types at once.
Allow specify both prestate and prestates url to allow overriding. Prestate takes priority.
ajsutton
force-pushed
the
aj/prestates-url
branch
from
ce1eae3
to
55330d3
Compare
ajsutton
force-pushed
the
aj/prestates-url
branch
from
55330d3
to
6ca26e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since prestates are downloaded based on their state hash, states for different VMs can be downloaded from the same source to simplify configuration and managed. The new
--prestates-urloption makes this possible and is used as the source of prestates if not overridden by a VM specific option.Since
--prestates-urlgets inherited for all VMs, the config now allows setting both...AbsolutePreStateand...AbsolutePreStateBaseURLoptions with the...AbsolutePreStateoption taking precedence. This ensures you can use--prestates-urlbut still override a specific game type to use a fixed prestate file.The aim is to make configuration much more generic so supporting new game types is easier.
Tests
Added unit tests and updated existing ones for changed behaviour.