Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPCM: AddressManager and ProxyAdmin assertions. #12370

Merged
merged 10 commits into from
Oct 8, 2024

Conversation

blmalone
Copy link
Contributor

@blmalone blmalone commented Oct 8, 2024

Adding additional assertions for:

  • AddressManager
  • ProxyAdmin
  • and all Proxy implementations (3 types of proxy)

Copy link
Contributor Author

blmalone commented Oct 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blmalone and the rest of your teammates on Graphite Graphite

@blmalone blmalone requested a review from mds1 October 8, 2024 17:47
@blmalone blmalone marked this pull request as ready for review October 8, 2024 17:57
@blmalone blmalone requested a review from a team as a code owner October 8, 2024 17:57
@blmalone blmalone marked this pull request as draft October 8, 2024 18:06
Copy link
Contributor

semgrep-app bot commented Oct 8, 2024

Semgrep found 2 sol-style-return-arg-fmt findings:

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

@blmalone blmalone marked this pull request as ready for review October 8, 2024 20:08
@blmalone blmalone requested a review from mds1 October 8, 2024 20:08
@mds1 mds1 enabled auto-merge October 8, 2024 20:31
@mds1 mds1 added this pull request to the merge queue Oct 8, 2024
Merged via the queue into develop with commit a05feb3 Oct 8, 2024
62 checks passed
@mds1 mds1 deleted the 10-08-opcm_addressmanager_and_proxyadmin_assertions branch October 8, 2024 20:42
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
)

* OPCM: AddressManager and ProxyAdmin assertions.

* fix: Added logic for proxy types to check implementations.

* fix: touch ups for RDP impl checking.

* fix: fully fledged proxies added to tests because of new assertions.

* fix: removing console2 lib.

* fix: semgrep complaining.

* fix: comment cleanup and logical split to avoid stack too deep error.

* fix: adding comment back in.

* fix: added natspec comments for new DeployUtils functions.

* fix: removed unused imports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants