feat(ct): add checks for unused imports #12348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
packages/contracts-bedrock/scripts/checks/unused-imports/main.go
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/checks/unused-imports/main.go
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/checks/unused-imports/main.go
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12348 +/- ##
===========================================
- Coverage 64.10% 63.91% -0.19%
===========================================
Files 52 52
Lines 4312 4312
===========================================
- Hits 2764 2756 -8
- Misses 1374 1383 +9
+ Partials 174 173 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
A few things in this commit: - Adds a new check for unused imports in contracts - Cleans up contracts based on that check - Removes several files that aren't being used anymore
smartcontracts
force-pushed
the
sc/check-unused-imports
branch
from
1d25c5c
to
393688d
Compare
tynes
reviewed
Oct 7, 2024
tynes
approved these changes
Oct 7, 2024
|
This will wreck some of #12356. We should be explicit around merge plan to reduce conflicts |
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
A few things in this commit: - Adds a new check for unused imports in contracts - Cleans up contracts based on that check - Removes several files that aren't being used anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things in this commit: