-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contracts-bedrock: cleanup FeeVault
#12338
Conversation
Updates the `FeeVault` to follow modern conventions used in the repo by moving to usage of interfaces rather than implementations. Also moves the `FeeVault` into the `L2` package as its only really useful on L2. This is meant to reduce the diff for the Stanard L2 Genesis by breaking up the refactor into its own small PR.
Semgrep found 1 Javadoc-style comments are not allowed. Use |
There is an issue with normalization of enums when they are return values
@smartcontracts I added the fee vaults to the ignore list in the interface script. They were giving the following error:
This requires normalization, which given you are rewriting this script in Go, I didn't want to duplicate the work. This issue arises even if the I recommend we think a bit from first principles rather than just staying within the confines of cast's behavior, ie we could ask for an update to |
* contracts-bedrock: cleanup `FeeVault` Updates the `FeeVault` to follow modern conventions used in the repo by moving to usage of interfaces rather than implementations. Also moves the `FeeVault` into the `L2` package as its only really useful on L2. This is meant to reduce the diff for the Stanard L2 Genesis by breaking up the refactor into its own small PR. * contracts: update semver-lock * semver-lock: fixup * cleanup: refactor * lint: fix * snapshots: regenerate * interface check: ignore fee vaults There is an issue with normalization of enums when they are return values
Description
Updates the
FeeVault
to follow modern conventions used in the repoby moving to usage of interfaces rather than implementations. Also
moves the
FeeVault
into theL2
package as its only really usefulon L2. This is meant to reduce the diff for the Stanard L2 Genesis
by breaking up the refactor into its own small PR.