contracts: clean up deploy script abstractions #12336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the implementation deployments into `deployImplementations` and the initializations into the initizer function so that things are grouped more logically. Even though we use OPSM for modern deployments, the legacy code is still in the repo. This change makes it easier to implement Standard L2 Genesis, where we depend on the `OptimismPortal` being initialized before the `SystemConfig`, since the `SystemConfig` makes calls to the portal during its `initialize` call.
|
Looks like a failing e2e test |
Modularizes the functionality more
smartcontracts
approved these changes
Oct 5, 2024
protolambda
pushed a commit
that referenced
this pull request
Oct 7, 2024
* contracts: clean up deploy script abstractions Move the implementation deployments into `deployImplementations` and the initializations into the initizer function so that things are grouped more logically. Even though we use OPSM for modern deployments, the legacy code is still in the repo. This change makes it easier to implement Standard L2 Genesis, where we depend on the `OptimismPortal` being initialized before the `SystemConfig`, since the `SystemConfig` makes calls to the portal during its `initialize` call. * op-e2e: remove dependency on contracts existing Modularizes the functionality more * lint: fix
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
It began to error after #12336
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* contracts: clean up deploy script abstractions Move the implementation deployments into `deployImplementations` and the initializations into the initizer function so that things are grouped more logically. Even though we use OPSM for modern deployments, the legacy code is still in the repo. This change makes it easier to implement Standard L2 Genesis, where we depend on the `OptimismPortal` being initialized before the `SystemConfig`, since the `SystemConfig` makes calls to the portal during its `initialize` call. * op-e2e: remove dependency on contracts existing Modularizes the functionality more * lint: fix
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
It began to error after ethereum-optimism#12336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the implementation deployments into
deployImplementationsand the initializations into the initizer function so that things
are grouped more logically. Even though we use OPSM for modern
deployments, the legacy code is still in the repo. This change
makes it easier to implement Standard L2 Genesis, where we depend
on the
OptimismPortalbeing initialized before theSystemConfig,since the
SystemConfigmakes calls to the portal during itsinitializecall.