op-signer, op-node: Integrate op-node with op-signer for block payload signing #12325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mininny
force-pushed
the
feature/mininny/integrate-op-signer-op-node
branch
from
0231b08 to
ebeb2a4
Compare
mininny
commented
Oct 7, 2024
mininny
commented
Oct 7, 2024
mininny
force-pushed
the
feature/mininny/integrate-op-signer-op-node
branch
from
9860c29 to
12c4820
Compare
protolambda
reviewed
Oct 26, 2024
mininny
force-pushed
the
feature/mininny/integrate-op-signer-op-node
branch
3 times, most recently
from
957e7f4 to
9844e61
Compare
mininny
force-pushed
the
feature/mininny/integrate-op-signer-op-node
branch
from
9844e61 to
3669e4c
Compare
protolambda
reviewed
Oct 31, 2024
mininny
force-pushed
the
feature/mininny/integrate-op-signer-op-node
branch
2 times, most recently
from
54083cc to
466f5ff
Compare
protolambda
approved these changes
Oct 31, 2024
…te signer configuration for block payload signing
mininny
force-pushed
the
feature/mininny/integrate-op-signer-op-node
branch
from
466f5ff to
7484aa0
Compare
mininny
force-pushed
the
feature/mininny/integrate-op-signer-op-node
branch
from
7484aa0 to
1be74b5
Compare
|
/ci authorize 1be74b5 |
Merged
via the queue into
ethereum-optimism:develop
with commit Dec 3, 2024
4de5c8c
45 checks passed
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
…d signing (#12325) * Initial implementation of integrating op-node with op-signer for remote signer configuration for block payload signing * op-service: remove the requirement for signer.address to be set when using op-service * op-service: add blockpayload_args to send to rpc opsigner_signBlockPayload * Implement mock rpc in gossip_test and apply review * Clean up tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design Doc: ethereum-optimism/design-docs#103
Description
This PR adds remote signer configuration for op-node when signing the block payload for p2p gossiping in sequencers.
For block payload signing,
domain [32]byte, chainID *big.Int, encodedMsg []byteare used. InRemoteSigner, these three arguments are hashed together to create a[32]bytesigningHash.The op-node then calls the
opsigner_signBlockPayloadrpc, which takes in aBlockPayloadArgsand returns[65]bytesignature.This signature is then used to gossip the p2p payload from the sequencer to other op-nodes.
To use remote signing, the following flags must be set:
See corresponding op-signer pr at optimism-infra: ethereum-optimism/infra#59
Tests
Additional context
Metadata