contracts-bedrock: fixes OptimismMintableERC721Factory test
#12306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contract is only used as a predeploy so it should be tested based on the L2 genesis generation setup. Ensures that the address is stored and labeled as part of in memory test setup, as well as updates the tests to work based on the predeploy. This is a small refactor to make future Standard L2 genesis work more simple. Also includes a small ABI fix to the `OptimismMintableERC721Factory` since this contract has not been updated to decouple immutable naming conventions from its ABI.
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
packages/contracts-bedrock/src/universal/interfaces/IOptimismMintableERC721Factory.sol
Outdated
Show resolved
Hide resolved
|
@smartcontracts can I get a review please 👉👈 |
skeletor-spaceman
approved these changes
Oct 7, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…um-optimism#12306) * contracts-bedrock: fixes `OptimismMintableERC721Factory` test This contract is only used as a predeploy so it should be tested based on the L2 genesis generation setup. Ensures that the address is stored and labeled as part of in memory test setup, as well as updates the tests to work based on the predeploy. This is a small refactor to make future Standard L2 genesis work more simple. Also includes a small ABI fix to the `OptimismMintableERC721Factory` since this contract has not been updated to decouple immutable naming conventions from its ABI. * snapshots: update * checks: fix * lint: fix * typo: fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This contract is only used as a predeploy so it should be tested based
on the L2 genesis generation setup. Ensures that the address is stored
and labeled as part of in memory test setup, as well as updates the
tests to work based on the predeploy.
This is a small refactor to make future Standard L2 genesis work more
simple.
Also includes a small ABI fix to the
OptimismMintableERC721Factorysince this contract has not been updated to decouple immutable naming
conventions from its ABI.