-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete FPACOPs and unused deploy functions #12261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maurelian and the rest of your teammates on Graphite |
maurelian
force-pushed
the
opcm/tests/delete-unused-funcs
branch
from
October 2, 2024 19:11
8dc9a90
to
edb5941
Compare
maurelian
changed the title
feat: delete unused deploy functions
feat: delete FPACOPs and unused deploy functions
Oct 2, 2024
maurelian
changed the title
feat: delete FPACOPs and unused deploy functions
feat: delete FPACOPs and unused deploy functions
Oct 2, 2024
maurelian
force-pushed
the
opcm/tests/delete-unused-funcs
branch
from
October 2, 2024 19:16
edb5941
to
d23d2bd
Compare
This also allows us to delete several deployX() functions from Deploy.s.sol
maurelian
force-pushed
the
opcm/tests/deploy-impls
branch
from
October 2, 2024 20:48
5b4da04
to
2426d15
Compare
maurelian
force-pushed
the
opcm/tests/delete-unused-funcs
branch
from
October 2, 2024 20:48
d23d2bd
to
85dc6c4
Compare
Semgrep found 2 require() must include a reason string Ignore this finding from sol-style-require-reason. |
tynes
approved these changes
Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: delete unused deploy functions
feat: Annotate functions used in FPACOPS scripts