packages/contracts-bedrock: fix lint issue #12215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clarify that 'just update-foundry' needs to be run from the root of the repo in check-foundry script. Usually the user will be in contracts-bedrock/src when seeing this message, and the justfile there doesn't handle it.
smartcontracts
approved these changes
Oct 1, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 1, 2024
31e244c
61 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
- clarify that 'just update-foundry' needs to be run from the root of the repo in check-foundry script. Usually the user will be in contracts-bedrock/src when seeing this message, and the justfile there doesn't handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix lint issue introduced in Holocene: extensions to L1Block.sol #12096
clarify that 'just update-foundry' needs to be run from the root of the repo in check-foundry script. Usually the user will be in contracts-bedrock/src when seeing this message, and the justfile there doesn't handle it.