-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interop: Update Inputs (rebased) #12204
Conversation
9401c1e
to
0ff61f1
Compare
0ff61f1
to
5dcf4e6
Compare
5dcf4e6
to
7681290
Compare
Edited the |
b8e7b6e
to
2122e1a
Compare
Fixed a test that still relied on the old RPC, and dropped a TODO from code for which I opened an issue: #12357 |
Semgrep found 4
Named return arguments to functions must be appended with an underscore ( Semgrep found 2
Malformed revert statement style. Ignore this finding from sol-style-malformed-revert.Semgrep found 22
Inputs to functions must be prepended with an underscore ( |
* op-node,op-supervisor: feed local-unsafe/local-safe/l1-finalized data to supervisor * op-node,op-service,op-e2e: wip, fix interop op-node tests * post-rebase compilation fixes * BlockRef * op-supervisor: fix service test, cleanup todo * op-supervisor: link TODO comments to issue * interop: fix e2e action test --------- Co-authored-by: protolambda <[email protected]>
this is a recreation of
#12094
but I didn't want to potentially mess up proto's original branch with bad rebase choices.
I pulled in develop and used the
-X theirs
strategy, and then usedrebase -i
to remove all the redundant commits that were stuck in the PR. I looked over the PR and compared to thegit diff HEAD~~
and it looks like it correctly removed just the parts that already got merged. But if I got that wrong, I can move back to the original branch.